Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4473647rwb; Tue, 20 Sep 2022 14:40:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6tcfr3ll2JOHoeYLNlEAXh2JMrFfpp94GimbYzlUbUwRzp1vpK6CSjMAOKNagK95d1yctB X-Received: by 2002:a17:907:a0e:b0:780:72bb:5ce4 with SMTP id bb14-20020a1709070a0e00b0078072bb5ce4mr18968624ejc.234.1663710022445; Tue, 20 Sep 2022 14:40:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663710022; cv=none; d=google.com; s=arc-20160816; b=rtvjqiOe2FRSga34bdHLa5F0kTJtR1G/OQwtsUQN56qVh4ri++czFNa3HLhfm8gw87 nadGkY53gWpnAYMN1wpoZrkruxwIsRGAfCXYJNShT5EUX0LzI7V3TPlSp2b3y5qLWdhz M500XTNdqNSvOHesnUSyT3/8EFRDUvgEYtHrMsBfU0PRHP9KsavrFjBcWFU6gp2A4tdx IVDvojWjJJG3oiEtSKtVAaV13x9CPRwNhTt4BXj7HcQZcFo+qvd9m0xOmuDBmnchQUtw fO5l3J5cfBg8CcvXXH++moX3I7sBEEh0YrmzOwrBB+u3C+FZr9eP6OzpI3J3DCkcJ0Uw TRcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=hIR0tDbiJiurJ+3nIpD24XwlfVqjglmDIaa4a9tm0AM=; b=vMkdVgfoAhlJghQZiBC0m9eP0v0HUHp0hLUNOnyGf9KCm2l66na6JeAruRuCFBGSxM zjYS8gWFosL0TfNOArsOPD1abBOTHhMDNKirmj4FIsYihr/E0KIzlyXmfdRbR+buAqnU P5hfW2ySMDhw5t4WjXNwqZBHR+1AfTOtiF16mZa9EdQxFDKH7FUrlxI8/xamg6I4N6wE Af3t6Fc2XauIcnfQouDa3kXw2ANCVkFMK0sPXTr0ciupmYDMtswN04NCuFZ4Bxd25an6 Rv5mWQVDFJOa0onfPfbpGoQPtduGoy9G/OrtqOluXkQHen+dz8X3zYqeDR7YwHJK4FrJ U+WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="OK/05vPE"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xf12-20020a17090731cc00b00781dc03ace4si884988ejb.438.2022.09.20.14.39.57; Tue, 20 Sep 2022 14:40:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="OK/05vPE"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229845AbiITVB2 (ORCPT + 99 others); Tue, 20 Sep 2022 17:01:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229605AbiITVBY (ORCPT ); Tue, 20 Sep 2022 17:01:24 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F4DD631A; Tue, 20 Sep 2022 14:01:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4EA8AB82CA0; Tue, 20 Sep 2022 21:01:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8546FC433C1; Tue, 20 Sep 2022 21:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663707681; bh=hIR0tDbiJiurJ+3nIpD24XwlfVqjglmDIaa4a9tm0AM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OK/05vPEfJ4K0n5Pmv+NE7pojPUuEuiCl1UAGTOVORnTN9Mmeu6t/RVp84n+0ne34 Csl1pCEX+oJfkhqeO9TvUgK+JcwA6Kti0gL3KVHcUcpxgnWMJJB7JxvWCpkoZtBcL9 3MH4s6lp1wsoUtwOlrXChA9nQyNFQTLvR3IYyroKhBkXBHIFq2eJDGbmaZZLzbnCes MVFqpJ9QHOi6pVBAreLnQRlgCDmAB0M7Kj+tQqefv1UQaimVCvx9WXoU1BxHcgF71S /+D0mVGex+GTl033K3p4ca9M9ggUxCQUOvz6CpC2vBeeFgB9TbGabQMGaCggzs4wxg C4zseSd/9NADQ== Date: Tue, 20 Sep 2022 14:01:19 -0700 From: Jakub Kicinski To: Vladimir Oltean Cc: netdev@vger.kernel.org, Vinicius Costa Gomes , Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Voon Weifeng , Vladimir Oltean , Kurt Kanzenbach , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next 7/7] net/sched: taprio: replace safety precautions with comments Message-ID: <20220920140119.481f74a3@kernel.org> In-Reply-To: <20220915105046.2404072-8-vladimir.oltean@nxp.com> References: <20220915105046.2404072-1-vladimir.oltean@nxp.com> <20220915105046.2404072-8-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Sep 2022 13:50:46 +0300 Vladimir Oltean wrote: > The WARN_ON_ONCE() checks introduced in commit 13511704f8d7 ("net: > taprio offload: enforce qdisc to netdev queue mapping") take a small > toll on performance, but otherwise, the conditions are never expected to > happen. Replace them with comments, such that the information is still > conveyed to developers. Another option is DEBUG_NET_WARN_ON_ONCE() FWIW, you probably know..