Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: b52gPdzIWvL7eXF7zPPq9tXun54L0CmSPx/ieq8MNwfGvACAgMZABORZbWI6GZ7UOMAvm23Y/j
 QDQZjzgQcLq/cNvKtr/6l3+zLfAKzx8C9qPF8QIin2m7Eoiy2QM6s/6jGfFcQLs16cFZdTsr9V
 qTmNh9hHPe7OMz25x3UWdtsLq8KNiA1sf2szWcGgRlE8S+6LreL40r2DuSmMsqQW2UDDNmsqxP
 gwFmd9t4Q7C1sVAKsXQalGTuEhDc0UBSVptAZYU7UVNGBoTR+34hG+6KeVjb3ErQNqvwNAI6vr
 h2c3QNCLXnt0JIHh9/qDkjOa
IronPort-SDR: KSMTrrCySjebUuryG1VPGpFalH9S1GfYe/eDO9rL6dnMT4dEWMWbSPiDYAdV3rAD03c6uOKVZT
 BUI/sUzaBzFaHxuI2Jx7T8japJvaoVUr+oopfZdfeuNzG6ZO8L9r4dOIxaA0rLelUscJlGuRKE
 02HLH5DGqTvdSDm4IWr0JxxpzsoCtknXZCPnkodL+Q2aMEADzYw+UBMZ6p3hBQWbi6ETu4/2dF
 NhDTiVOt/5a9dTAJl0tUXtkPOHvwm3hoGxRzQcMdBkhdxH4ejnbI3go3ZNHR+yk5OZliLNuHBj
 +vE=
WDCIronportException: Internal
Message-ID: <67b11e85-3e4e-beb7-4a2b-ef856207b227@opensource.wdc.com>
Date:   Wed, 21 Sep 2022 07:03:33 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH 1/6] scsi: core: Use SCSI_SCAN_RESCAN in
 __scsi_add_device()
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, hare@suse.de, hch@lst.de
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, brking@us.ibm.com
References: <1663669630-21333-1-git-send-email-john.garry@huawei.com>
 <1663669630-21333-2-git-send-email-john.garry@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1663669630-21333-2-git-send-email-john.garry@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/20/22 19:27, John Garry wrote:
> Instead of using hardcoded '1' as the __scsi_add_device() ->
> scsi_probe_and_add_lun() rescan arg, use proper macro SCSI_SCAN_RESCAN.
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
>   drivers/scsi/scsi_scan.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index ac6059702d13..3759b1a77504 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -1588,7 +1588,8 @@ struct scsi_device *__scsi_add_device(struct Scsi_Host *shost, uint channel,
>   		scsi_complete_async_scans();
>   
>   	if (scsi_host_scan_allowed(shost) && scsi_autopm_get_host(shost) == 0) {
> -		scsi_probe_and_add_lun(starget, lun, NULL, &sdev, 1, hostdata);
> +		scsi_probe_and_add_lun(starget, lun, NULL, &sdev,
> +				       SCSI_SCAN_RESCAN, hostdata);
>   		scsi_autopm_put_host(shost);
>   	}
>   	mutex_unlock(&shost->scan_mutex);

Looks good.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research