Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4614411rwb; Tue, 20 Sep 2022 17:10:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5imA/dNI+WDvfyAwnCXIUHowCMzkoswIELrLCQfzjjKWUVBnXqpx+njT7Y5I7Lj6c3+4Qx X-Received: by 2002:a63:a505:0:b0:438:675d:caee with SMTP id n5-20020a63a505000000b00438675dcaeemr23204650pgf.576.1663719055921; Tue, 20 Sep 2022 17:10:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663719055; cv=none; d=google.com; s=arc-20160816; b=OHMfk0ou5vmrcA4HB7ZbmIiXPO2bnXhLoUPnmfQ6/Or2N4Gq8LgpanVIyPrP9YXdhs pIHqq8VgSCJAaKFDK/YEIi5fuxhb+HEhJhjXJ7+nchBNHgmEIR3imfnCF+6POLoBPiUm v9GZG0QRS+Bzp/4JeB92TZylCKUVl0sCDXyNJh12rI6j91oTgKtqeNW1vrgGvIgfigy/ XgspRZVQp6Wm3UAv/N8cMZxpjMDLn6H9OE3lntJ+Ta4sAsHl27wyn0FUdINT8TxEZv/D atY0l2+YrnzlMGwja4BvrNY7uIia/XFSvnpiF67N48aO9yUTHH4jdQtSYBFspVe9e4gj RdqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=7B66HfNp0wPQB5A6vT6O62g8aAJgYt8bYjvlRjBMk6Y=; b=kFLe9ZKgXziy4//3CKvO0vhAgGxQKk1AViBplKW81AW20owkGQnKmVGCMmSK7EfAYu p/Kq5Js7SdqdkBtmKaVGZqzD65wxl7ZEh/QYvjVV/4jiU2nD57H/1SJRi8IK0r5Sl3L/ 3Ue7jKx9vXmx7QP7PmYrxGniFmsVGxOnYj897Il4RA+TDIOLJNPvEDIg/Dzvb/v/UZfV mEHsmxUMnsPpZosmr3suRbd5YhByUtazrE+CBjsYUKNDgiNvcpvi4dCq0DFiZJepih8t HnRqAAahKWihPlH7HDzdZH+ghWmCiFZMyXi617/V/o5l1S6X7R8LYlVGJPA10aOSPQwD kvdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fFVoFbmD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u204-20020a6279d5000000b0054252c63d75si1207315pfc.98.2022.09.20.17.10.42; Tue, 20 Sep 2022 17:10:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fFVoFbmD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230326AbiITXrg (ORCPT + 99 others); Tue, 20 Sep 2022 19:47:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229847AbiITXre (ORCPT ); Tue, 20 Sep 2022 19:47:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD08027DFE; Tue, 20 Sep 2022 16:47:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4915862E9B; Tue, 20 Sep 2022 23:47:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 681D4C433D6; Tue, 20 Sep 2022 23:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663717652; bh=7B66HfNp0wPQB5A6vT6O62g8aAJgYt8bYjvlRjBMk6Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fFVoFbmDNNBul1CLGQBrbPtOnM7wYvkmqqOOvBbrhNcsVxj2LSCyedDx3gSmp/Ndm eSOSbNQR/78vhHtx7I85JpOgQPEJ8Bcg/UP/Ws6VnFSXtALmjlpQbvpg6lUO4Yx0n8 oRIYLRgGaGHyWmdSXvG5EHi9ZAU5jEaIDa+2ao3Kp2aQOF6MVbjmbPKcTSd9OAvY8i B5A4gp0WoIZ3tvoWV48Kh1rYFKn6yP0bHiHmT0FsgASARnbnhZLpoNErKC1HJ5tUWt LpdgYpMQtkAcF49B9ghax175ZWeKtOUYXFN92SRLfcAmKtjA/Wf97lwOPiCPIzd92L doSXsDFf5jsmg== Date: Tue, 20 Sep 2022 16:47:31 -0700 From: Jakub Kicinski To: Li zeming Cc: aelior@marvell.com, manishc@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] linux: qed: Remove unnecessary =?UTF-8?B?4oCYTlVMTA==?= =?UTF-8?B?4oCZ?= values values from Pointer Message-ID: <20220920164731.49856668@kernel.org> In-Reply-To: <20220919020614.3615-1-zeming@nfschina.com> References: <20220919020614.3615-1-zeming@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Sep 2022 10:06:14 +0800 Li zeming wrote: > The pointer p_ret is first assigned and finally used as the return value > of the function. This patch doesn't make anything substantially better.