Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4647914rwb; Tue, 20 Sep 2022 17:52:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5RabxzBMvsaXnVvqrF2RrW+NbUUeJh/+H64rc2WEu6anrqgWwIVUUxUNWNPQS4/ZwlG9F0 X-Received: by 2002:a17:907:8a01:b0:780:d2b8:61aa with SMTP id sc1-20020a1709078a0100b00780d2b861aamr14636603ejc.454.1663721521163; Tue, 20 Sep 2022 17:52:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663721521; cv=none; d=google.com; s=arc-20160816; b=uatWKJIdRFstu+nqUpyv53iJAjk6Fjitw6UblmBQoTTB2egBpEm+L+aekdD7BpUmbe CifQIcsRjfO4Bz40iq/jtXJfZ3jHHNGef4lZS38K3/5hExeXrvKZNHPAlrmq5/KDUqpj Vfp0nW+d+tnP7HuNiFMZFlRneSM733XbxLEmsDKMuAiIwEM59gDR4+JzwNMWmSlzxi97 fnBduH3FKWVbg7/Kt0roZce3AS+yFA9WxmwGQVvAwx1hy1APa6uMGKVsgLZ+UIRNAxjp 2t5VCSpm7S/o4r0lQ2bc62R6yyJ6j8MZfHYZ37TP7WOnRhAznfKm5iTmEbX3Ohdmj5hr 7rgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ES4lHOfi36UTOt/Tzs3dS9IkBYhPXBuVpySG7uoJLyM=; b=Oqu0H/Wgq2Gs2Ei1NKztv8vzMruPFVw2B4cfW69SRD8JFp8xYIemoyY8Q3KTfQlscP 3Eyr4DSAgwewH2ybp9vrUs8GvSkCDKvcBVB+Sy20Nf4fJwGXG1D2IqQ+a9rm0wLAgnu3 Kq+1u/cH6q2JvnNi1cnOICZU0g9Sq2wY3K7YGOVWAeQ0R0jceKx6RdpATS+xqKz15GlC QeQODzoQB8jt0qpiq9hgg4cg+oxW9cgDOYPEhegmGtMqPkRgiSyu0Eo30HS4K42Gt1I4 UOpD/0/zYMSLR/3yFBuzB95D/hsYfpYUNs4uHguCTPwHdXRcI2tJRMhkNbzGBWMwBNiE L2Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JcR1t0aP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k17-20020a170906129100b0077081057215si968760ejb.956.2022.09.20.17.51.35; Tue, 20 Sep 2022 17:52:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JcR1t0aP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231361AbiIUAjF (ORCPT + 99 others); Tue, 20 Sep 2022 20:39:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230388AbiIUAjE (ORCPT ); Tue, 20 Sep 2022 20:39:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF0EBBAF; Tue, 20 Sep 2022 17:39:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 55FCBB81178; Wed, 21 Sep 2022 00:39:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FAD1C433D7; Wed, 21 Sep 2022 00:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663720741; bh=ES4lHOfi36UTOt/Tzs3dS9IkBYhPXBuVpySG7uoJLyM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JcR1t0aPrNk/5OXhoyZew1qhTELtVUfQzsDPvSjmVMHqlivyvY409ghnkIROD0NdD QHmp8WR9QgNIq3XyPTvi42L6sTEW/2JGfKKa7uAAKace0hkuUHXpk/BDrirq/76FXA BFK4PPtBIt0VmdGviF/g8k/EGPZx9+At7ttrgVZWTFQzlBylAM0LSOJUh/+4790G0V UNCNt0TRgg98NeIPDzj7BkJ8UyxcbaX4yWgIiZ+Bc0NINa2BHdz3Zo0W7n1VZxLZZN QEeb2h5r9JbQvF0ycchFnpK+WjlsTgaacXYKB4ialZ7HL/xlPzrZ6sQfXP4zKdgYDH oo+U+ODBhhJJg== Date: Tue, 20 Sep 2022 17:38:59 -0700 From: Jakub Kicinski To: Peilin Ye Cc: Eric Dumazet , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Paolo Abeni , Peilin Ye , Cong Wang , Kuniyuki Iwashima , Alexei Starovoitov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] udp: Refactor udp_read_skb() Message-ID: <20220920173859.6137f9e9@kernel.org> In-Reply-To: <03db9765fe1ef0f61bfc87fc68b5a95b4126aa4e.1663143016.git.peilin.ye@bytedance.com> References: <03db9765fe1ef0f61bfc87fc68b5a95b4126aa4e.1663143016.git.peilin.ye@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Sep 2022 01:15:30 -0700 Peilin Ye wrote: > Delete the unnecessary while loop in udp_read_skb() for readability. > Additionally, since recv_actor() cannot return a value greater than > skb->len (see sk_psock_verdict_recv()), remove the redundant check. These don't apply cleanly, please rebase?