Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Sep 2022 00:46:23 +0000
To:     Daniel Ogorchock <djogorchock@gmail.com>
From:   Johnothan King <johnothanking@protonmail.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH v2] HID: nintendo: check analog user calibration for plausibility
Message-ID: <f468kPVeU3xgbeIr3VAo9yn79tU-Wk94UJlr9uMsGP-XxyE1MbYejfHRmGsyhoujW5vwobD6wwfRhSjAtZdtlfm-ccqNxkCvSuHMnurhlbc=@protonmail.com>
In-Reply-To: <CAEVj2t=F-zF9jTmfJuqx=DRFopygKDXVv0wX91nRLqP1QZqS_w@mail.gmail.com>
References: <RINjeKS0brZzIa6F-fgBKuiHrrcZB8zfTg_chbQIT3BRLqx-l9SmsxvV3LXx7upuctFCki33uAIhXNsM92YWTub8vbzSQHcJibhPkN5ijB8=@protonmail.com> <CAEVj2tn8byGn2RHmvYc77rv2BZkApW3yQ5qSDDzNGxhbygO2Ag@mail.gmail.com> <CAEVj2t=F-zF9jTmfJuqx=DRFopygKDXVv0wX91nRLqP1QZqS_w@mail.gmail.com>
Feedback-ID: 1750573:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

I'll submit a third version that fixes the warning string. I've also
made another minor tweak to joycon_use_default_calibration() for
the v3 patch.

- Johnothan King

------- Original Message -------
On Tuesday, September 20th, 2022 at 3:06 PM, Daniel Ogorchock <djogorchock@=
gmail.com> wrote:


> > static const u16 DFLT_STICK_CAL_CEN =3D 2000;
> > static const u16 DFLT_STICK_CAL_MAX =3D 3500;
> > static const u16 DFLT_STICK_CAL_MIN =3D 500;
> > +static void joycon_use_default_calibration(struct joycon_ctlr *ctlr,
> > + struct joycon_stick_cal *cal_x,
> > + struct joycon_stick_cal *cal_y,
> > + const char *stick, int ret)
> > +{
> > + hid_warn(ctlr->hdev,
> > + "Failed to read %s stick cal, "
> > + "using defaults; e=3D%d\n",
> > + stick, ret);
> > +
>=20
>=20
> Sorry, missed this on my first readthrough. I think the coding style
> mentions not to break up the logged string into multiple lines, since
> it'll harm greppability.
>=20
> -Daniel