Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4659625rwb; Tue, 20 Sep 2022 18:05:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5HdXiKfUHvh7Eoq8UfkZdarqDBWhOPi8SbKf36ZOvfMv9jlcAiBuKsUK3LVB6sSvoDqgxo X-Received: by 2002:a17:903:22d1:b0:178:3d35:dfce with SMTP id y17-20020a17090322d100b001783d35dfcemr2322909plg.16.1663722344757; Tue, 20 Sep 2022 18:05:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663722344; cv=none; d=google.com; s=arc-20160816; b=0PQlz9QublXZCY3egfHe+RtW58yj/KHfezK+dcH4KTIIjm9qnSSoE/ZLUWTf+y5blV xNRoOh7kDra9wpf6SRbpiryAzwLCwatTVlcRhqlnDsdYrApD1l1nqHBd5jCZJ6ZUlGW1 AC7tSZo7uDQ/GCk4G57Czl7R/mXdhw7Nlllm9XOCKA6KXDG2hF8mg7w3+lFQiP4rWLvD INNDOwft6KSTAHyuiPEPXYrOtCQfm4IRnkvzGTe/eNYpq81WveFkKxZmOJuN70mA8wpN 0g8n5ei2MN+/o1KuC6PxoZtRH/iizWkOFxnsydgxA3dX6YSjS/VNR1Cc+wooCVNYZ2k2 /gtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=nfMr6t57t7fAwwXuaYKyJaa94f0xaCt1ih1ODoBLugM=; b=tmvzzrLNIZxgWGcR9kbfubGasi1WkhMtvageNt1oCuIhVa2PqYk1J/3KsCBKc6an0Z ivk2TJs7f1rsizsIsxFUqvZfahMxu0VyYm0yI6G1aqPbR+nIZj+z9Q3gbyfcfK64GjdR SLYw/slhonfCnOB8crHKwrrfyQhw/LRW9Ndul3XWRr5JvAMM43h+gy3IVJqptv5cYF1L ignZWnL1JD0UU1vo5XCaHKRqpnzwxVenM8872IvAjg02HH2kpExbchYTo7jRH6JvQILB s6mueGATj/GZAEiVnni/d8RHHxM6up56/LadI2POix0Z2dKrzJTkD6BX/jSiZhcyvzvw jT4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I++YjRKd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h6-20020a63df46000000b00435b18f71bfsi1314469pgj.471.2022.09.20.18.05.33; Tue, 20 Sep 2022 18:05:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I++YjRKd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230369AbiIUAlA (ORCPT + 99 others); Tue, 20 Sep 2022 20:41:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbiIUAk5 (ORCPT ); Tue, 20 Sep 2022 20:40:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A4D14362B; Tue, 20 Sep 2022 17:40:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2F788B82DC4; Wed, 21 Sep 2022 00:40:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FE9BC433C1; Wed, 21 Sep 2022 00:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663720853; bh=MWlEw1UNRXi3JxOk0I3huE7q55AKj+oZp9V5gN/1Zdc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=I++YjRKdI0zD1tkCO51gbFlBwiSDBKlfCD6c7OYxEsTSXyTFtRMPi+/r4UQP6GQ10 M/cgyGPdypYcGOLi7hxiIdC0AUhbmjFqOYsICzw2DNxU1VT1bdDb/+5uU/3dKIu6p3 gP3xPJMTVQtpiu+2QvMA0EOzf24JeNJZKJBnlwL3P8lsO3sOx9qbg9FvvX4us2X4rE OMqrSumpDVXvUL3N5y4CTV0o4X5Va4IC8UVcfjd8SmMU7mik7JPWJ4tIXY/Rvs9ZCY ynOZDa7jL34aiurlNB9GrLQaZUHj30/bZzvgZ8w/F7RQGsongu1mZIrEVVBKqVpo1k qQHXrY5jD4vEQ== Date: Tue, 20 Sep 2022 17:40:52 -0700 From: Jakub Kicinski To: Peilin Ye Cc: Eric Dumazet , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Paolo Abeni , Peilin Ye , Cong Wang , Kuniyuki Iwashima , Alexei Starovoitov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] udp: Refactor udp_read_skb() Message-ID: <20220920174052.47d9858b@kernel.org> In-Reply-To: <20220920173859.6137f9e9@kernel.org> References: <03db9765fe1ef0f61bfc87fc68b5a95b4126aa4e.1663143016.git.peilin.ye@bytedance.com> <20220920173859.6137f9e9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Sep 2022 17:38:59 -0700 Jakub Kicinski wrote: > On Wed, 14 Sep 2022 01:15:30 -0700 Peilin Ye wrote: > > Delete the unnecessary while loop in udp_read_skb() for readability. > > Additionally, since recv_actor() cannot return a value greater than > > skb->len (see sk_psock_verdict_recv()), remove the redundant check. > > These don't apply cleanly, please rebase? Ah, it's the WARN_ON_ONCE() change. In that case please resend after net is merged into net-next (Thu evening).