Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Voon Weifeng <weifeng.voon@intel.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 7/7] net/sched: taprio: replace safety
 precautions with comments
Thread-Topic: [PATCH v2 net-next 7/7] net/sched: taprio: replace safety
 precautions with comments
Thread-Index: AQHYyPEMssHTbOdWeEqTjPVnldStm63o1mCAgAA2g4A=
Date:   Wed, 21 Sep 2022 00:16:26 +0000
Message-ID: <20220921001625.jwpr5r5tneyoxect@skbuf>
References: <20220915105046.2404072-1-vladimir.oltean@nxp.com>
 <20220915105046.2404072-8-vladimir.oltean@nxp.com>
 <20220920140119.481f74a3@kernel.org>
In-Reply-To: <20220920140119.481f74a3@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YO6UBvcO76Z7InrGI7AXSdyw9Xz1drV2cp7rN81KVoXJVVIWnIS5fbKu8dQK?=
 =?us-ascii?Q?BF1cWt2MKMIley7TRDgd5cyamgtE+a0Vh0fz1RrleFJLxw+wxwgqnjQtKNY8?=
 =?us-ascii?Q?YXv4HzhgKN82FsLg1eS+7rKjCbAhu23eD8OaFtMI0H8Yb9yhCA/8SaVdGgsr?=
 =?us-ascii?Q?c0Lcgaxv59O5/MHm8Zj0Zk9K6HLy/pLaoohzJAKBgvQqDm9Ae7AO/BzM73kH?=
 =?us-ascii?Q?fAB429WcMFQUPgIUEUUcJG2FQ5LBI8L7SMCFqs98e6xMEehwRpW3CekdC6hh?=
 =?us-ascii?Q?1xagEOrIE64gruTH0b3CJXlfaC7wKG5KSFN8+v86ZHw6X2eEIqZ2xPQsqnZN?=
 =?us-ascii?Q?Q5e8rz/Yqx2/gdJdYZpFH5TJDUsD04bb0WhwoXU/q5nSbNmPBFGqoMgkI4EZ?=
 =?us-ascii?Q?xJiJHnJTfOcJZE8oezCS32gwFTwnpp0a/fChRhKGyEQ/UaAIzRkIyGX0RBmO?=
 =?us-ascii?Q?DFuI9te1M1sOEktHA81CVtLgBhjWy4ISdCxNBtHCCJg+VLW+Rn1Bpp1SPf+s?=
 =?us-ascii?Q?cB4sDhToofnW0u3RjcX+UgVrRgCFrNCwDynKgaeyS8nE7f2nyTllTv6DGKzP?=
 =?us-ascii?Q?wnNzq0+B0x0/9LofxMCR5DHYceYob4BsNwzdrlK2GGSAtq1TmMkp1N2LPHuB?=
 =?us-ascii?Q?43fbKc3tzTBW80MwpD4i4UhoT1yLQzCCgK2UJ1j9o1kJru8woZsI0lNIk2m5?=
 =?us-ascii?Q?MzSRbAn1ilblh9YuJ4JNYrGn+7vdzCGMLeYQaH7h0w2u9B24h4GC29qB215a?=
 =?us-ascii?Q?dKgqxUbg+d2NLD1YfYJVJaF9T1uxSKJSyWs9xXl6X9jJVMNOpmQ+46BmuiCc?=
 =?us-ascii?Q?bRJrnLyvpsMcjJln8LGhx/QiSw/ZxEylS8gdtHMVu/n2BNEuErw1yrybCxpW?=
 =?us-ascii?Q?YGMJFsDRXyzy0nBhjvUbikEtRkrv0ycwiUGn72RG4+7Ryty/pHgyEuklZ+Z1?=
 =?us-ascii?Q?w7xnVnq3AmTCcKrZ3gR2MmPXkcK+zO1hL0ZlYO9iCnhTYBm9Qb/vkkRdG4xp?=
 =?us-ascii?Q?690Yuj7Lsap4PwBrIeBolKzikFUr/F2cPXXMdMJ/24d7saN3PieovOWAi285?=
 =?us-ascii?Q?TDpXp6smI/iaZllYBR7Fb3zx2EvcQNKuKyDiBN09wMbLR2LuhmBSXGCSe4W+?=
 =?us-ascii?Q?R9hcCz5z/3EwaIShfjSjzXRwCIEu+XU5WthcF3kPNbXmksXGQUaKwSmRyDnr?=
 =?us-ascii?Q?xbvKutDvOS63xJOLn18INzeZETBH1PYVVHh+JNM3Ko+T0k7CLfW6DTkTb7Ld?=
 =?us-ascii?Q?L1H19ArPKLPwY4LjYAewfUzeNC9pRN/VLcCLEwSEwVVEYr+NQV2uA/rhC6KH?=
 =?us-ascii?Q?4HWQLwb1LOacPJRCrIWgcW20iMcbPmc/Ais+eEN7QYTBgua9KO1xMqkWh0Ge?=
 =?us-ascii?Q?QQwaDs5IvaTgCJOcH/BjW+Wrn7De0URtNICjmfJJgsxtnVD6C0B0tUNzi4wb?=
 =?us-ascii?Q?9LUwS+/4eEsPwUdfLI6LGmyj96gKTm/FPSEuh0bsumftMmmnVYa2ox3UD262?=
 =?us-ascii?Q?PoUzoDB4U2OZJh74gUT0f1k4x5sAh0wjSkiQaely7SwAxkwLsjY7Mh3RRGar?=
 =?us-ascii?Q?bLvIyhy+w7j8OlJ3YDtcAr4Br8xCL008jhvsjqBQoa0J12QMDutn8AfvwCVO?=
 =?us-ascii?Q?Ig=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <88DEC59C63C0EE4BB4DA596DB72F5FF8@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb83b97c-c914-4401-b1e9-08da9b6685fb
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 00:16:26.2555
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gx/MbOSPUoqRjzQhU4e2o/ANYmFjwhgLHhVmErj3PFMBjrnI5U1Vqe5CKb4h0BTfeOmK4lU1PtZPm4aTCZ3bIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9079
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 20, 2022 at 02:01:19PM -0700, Jakub Kicinski wrote:
> On Thu, 15 Sep 2022 13:50:46 +0300 Vladimir Oltean wrote:
> > The WARN_ON_ONCE() checks introduced in commit 13511704f8d7 ("net:
> > taprio offload: enforce qdisc to netdev queue mapping") take a small
> > toll on performance, but otherwise, the conditions are never expected t=
o
> > happen. Replace them with comments, such that the information is still
> > conveyed to developers.
>=20
> Another option is DEBUG_NET_WARN_ON_ONCE() FWIW, you probably know..

Just for replacing WARN_ON_ONCE(), yes, maybe, but when you factor in
that the code also had calls to qdisc_drop(), I suppose you meant
replacing it with something like this?

	if (DEBUG_NET_WARN_ON_ONCE(unlikely(FULL_OFFLOAD_IS_ENABLED(q->flags))))
		return qdisc_drop(skb, sch, to_free);

This won't work because DEBUG_NET_WARN_ON_ONCE() force-casts WARN_ON_ONCE()
to void, discarding its evaluated value.

We'd be left with something custom like below:

	if (IS_ENABLED(CONFIG_DEBUG_NET) && unlikely(FULL_OFFLOAD_IS_ENABLED(q->fl=
ags))) {
		WARN_ONCE(1, "Trying to enqueue skb into the root of a taprio qdisc confi=
gured with full offload\n");
		return qdisc_drop(skb, sch, to_free);
	}

which may work, but it's so odd looking that it's just not worth the
trouble, I feel?=