Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <63ca556b81bc2874d3f0a5b87ee0e2f7a4fdeb18.camel@mediatek.com>
Subject: Re: [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support for
 mt8188
From:   Jianguo Zhang <jianguo.zhang@mediatek.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        "David S . Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC:     Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Biao Huang <biao.huang@mediatek.com>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>
Date:   Wed, 21 Sep 2022 09:14:44 +0800
In-Reply-To: <3ed55b0d-6c14-79a1-b4c1-5764c667d195@collabora.com>
References: <20220920083617.4177-1-jianguo.zhang@mediatek.com>
         <20220920083617.4177-2-jianguo.zhang@mediatek.com>
         <3ed55b0d-6c14-79a1-b4c1-5764c667d195@collabora.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear AngeloGioacchino

	Thanks for your comment.

On Tue, 2022-09-20 at 15:22 +0200, AngeloGioacchino Del Regno wrote:
> Il 20/09/22 10:36, Jianguo Zhang ha scritto:
> > Add binding document for the ethernet on mt8188
> > 
> > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
> > ---
> >   .../devicetree/bindings/net/mediatek-dwmac.yaml        | 10
> > ++++++++--
> >   1 file changed, 8 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/mediatek-
> > dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-
> > dwmac.yaml
> > index 61b2fb9e141b..eaf7e8d53432 100644
> > --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> > @@ -20,6 +20,7 @@ select:
> >           enum:
> >             - mediatek,mt2712-gmac
> 
> Please keep the list ordered by name. MT8188 goes before 8195.
> 
We will adjust the order in next version patches.

> >             - mediatek,mt8195-gmac
> > +          - mediatek,mt8188-gmac
> >     required:
> >       - compatible
> >   
> > @@ -37,6 +38,11 @@ properties:
> >             - enum:
> >                 - mediatek,mt8195-gmac
> >             - const: snps,dwmac-5.10a
> > +      - items:
> > +          - enum:
> > +              - mediatek,mt8188-gmac
> > +          - const: mediatek,mt8195-gmac
> > +          - const: snps,dwmac-5.10a
> >   
> >     clocks:
> >       minItems: 5
> > @@ -74,7 +80,7 @@ properties:
> >         or will round down. Range 0~31*170.
> >         For MT2712 RMII/MII interface, Allowed value need to be a
> > multiple of 550,
> >         or will round down. Range 0~31*550.
> > -      For MT8195 RGMII/RMII/MII interface, Allowed value need to
> > be a multiple of 290,
> > +      For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value
> > need to be a multiple of 290,
> 
> For MT8188/MT8195
> 
We will adjust the order in next version patches.

> >         or will round down. Range 0~31*290.
> >   
> >     mediatek,rx-delay-ps:
> > @@ -84,7 +90,7 @@ properties:
> >         or will round down. Range 0~31*170.
> >         For MT2712 RMII/MII interface, Allowed value need to be a
> > multiple of 550,
> >         or will round down. Range 0~31*550.
> > -      For MT8195 RGMII/RMII/MII interface, Allowed value need to
> > be a multiple
> > +      For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value
> > need to be a multiple
> 
> For MT8188/MT8195
> 
We will adjust the order in next version patches.

> >         of 290, or will round down. Range 0~31*290.
> >   
> >     mediatek,rmii-rxc:
> 
> 
BRS
Jianguo