Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Hidenori Kobayashi <hidenorik@chromium.org>
Date:   Wed, 21 Sep 2022 10:32:12 +0900
To:     Sakari Ailus <sakari.ailus@iki.fi>
Cc:     Hidenori Kobayashi <hidenorik@chromium.org>,
        Dongchun Zhu <dongchun.zhu@mediatek.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: ov8856: Add runtime PM callbacks
Message-ID: <20220921013212.m7sqb4v7hk5rddfa@google.com>
References: <20220920020002.710533-1-hidenorik@chromium.org>
 <Yyl7spRDgJ+R39Pj@valkosipuli.retiisi.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yyl7spRDgJ+R39Pj@valkosipuli.retiisi.eu>
Precedence: bulk

Hi Sakari,

Thanks for your review!

On Tue, Sep 20, 2022 at 11:37:06AM +0300, Sakari Ailus wrote:
> Hi Hidenori,
> 
> On Tue, Sep 20, 2022 at 11:00:01AM +0900, Hidenori Kobayashi wrote:
> > There were no runtime PM callbacks registered, leaving regulators being
> > enabled while the device is suspended on DT systems. Calling existing
> > power controlling functions from callbacks properly turn them off/on.
> > 
> > Signed-off-by: Hidenori Kobayashi <hidenorik@chromium.org>
> > ---
> >  drivers/media/i2c/ov8856.c | 21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> > 
> > diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c
> > index a9728afc81d4..3f57bc30b78b 100644
> > --- a/drivers/media/i2c/ov8856.c
> > +++ b/drivers/media/i2c/ov8856.c
> > @@ -2200,6 +2200,26 @@ static int __maybe_unused ov8856_resume(struct device *dev)
> >  	return 0;
> >  }
> >  
> > +static int __maybe_unused ov8856_runtime_suspend(struct device *dev)
> > +{
> > +	struct i2c_client *client = to_i2c_client(dev);
> > +	struct v4l2_subdev *sd = i2c_get_clientdata(client);
> > +	struct ov8856 *ov8856 = to_ov8856(sd);
> > +
> > +	__ov8856_power_off(ov8856);
> 
> Could you refactor this a bit, changing the __ov8856_power_off() argument
> to struct dev *?

Sure. I'll make V2 with this refactoring. I'm guessing that we want the
same for __ov8856_power_on(). Please let me know if otherwise.

> > +
> > +	return 0;
> > +}
> > +
> > +static int __maybe_unused ov8856_runtime_resume(struct device *dev)
> > +{
> > +	struct i2c_client *client = to_i2c_client(dev);
> > +	struct v4l2_subdev *sd = i2c_get_clientdata(client);
> > +	struct ov8856 *ov8856 = to_ov8856(sd);
> > +
> > +	return __ov8856_power_on(ov8856);
> > +}
> > +
> >  static int ov8856_set_format(struct v4l2_subdev *sd,
> >  			     struct v4l2_subdev_state *sd_state,
> >  			     struct v4l2_subdev_format *fmt)
> > @@ -2540,6 +2560,7 @@ static int ov8856_probe(struct i2c_client *client)
> >  
> >  static const struct dev_pm_ops ov8856_pm_ops = {
> >  	SET_SYSTEM_SLEEP_PM_OPS(ov8856_suspend, ov8856_resume)
> > +	SET_RUNTIME_PM_OPS(ov8856_runtime_suspend, ov8856_runtime_resume, NULL)
> >  };
> >  
> >  #ifdef CONFIG_ACPI

Best regards,
Hidenori