Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 18:05:23 -0700
From:   Peilin Ye <yepeilin.cs@gmail.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Peilin Ye <peilin.ye@bytedance.com>,
        Cong Wang <cong.wang@bytedance.com>,
        Kuniyuki Iwashima <kuniyu@amazon.com>,
        Alexei Starovoitov <ast@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] udp: Refactor udp_read_skb()
Message-ID: <20220921010523.GA2835@bytedance>
References: <03db9765fe1ef0f61bfc87fc68b5a95b4126aa4e.1663143016.git.peilin.ye@bytedance.com>
 <20220920173859.6137f9e9@kernel.org>
 <20220920174052.47d9858b@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220920174052.47d9858b@kernel.org>
Precedence: bulk

On Tue, Sep 20, 2022 at 05:40:52PM -0700, Jakub Kicinski wrote:
> On Tue, 20 Sep 2022 17:38:59 -0700 Jakub Kicinski wrote:
> > On Wed, 14 Sep 2022 01:15:30 -0700 Peilin Ye wrote:
> > > Delete the unnecessary while loop in udp_read_skb() for readability.
> > > Additionally, since recv_actor() cannot return a value greater than
> > > skb->len (see sk_psock_verdict_recv()), remove the redundant check.  
> > 
> > These don't apply cleanly, please rebase?
> 
> Ah, it's the WARN_ON_ONCE() change. In that case please resend after
> net is merged into net-next (Thu evening).

Sure, but only the TCP part was merged [1] into net.  I just sent the
UDP part again [2], and will resend this patchset after both [1] and [2]
are merged into net-next.  Thanks!

[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=96628951869c0dedf0377adca01c8675172d8639
[2] https://lore.kernel.org/netdev/20220921005915.2697-1-yepeilin.cs@gmail.com/T/#u

Peilin Ye