Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [RFC PATCH] x86/syscalls: allow tracing of __do_sys_[syscall]
 functions
From:   Nadav Amit <nadav.amit@gmail.com>
In-Reply-To: <D0F82355-EB17-46A3-82AA-CC0B26344A08@gmail.com>
Date:   Tue, 20 Sep 2022 18:31:24 -0700
Cc:     "Steven Rostedt (Google)" <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Transfer-Encoding: quoted-printable
Message-Id: <72644F1F-7A13-4CC1-8C24-BE271323FE94@gmail.com>
References: <20220913135213.720368-1-namit@vmware.com>
 <2D09BBFE-45F3-4B9C-8734-D002CA99FD94@gmail.com>
 <Yymds595qthVSnt0@hirez.programming.kicks-ass.net>
 <D0F82355-EB17-46A3-82AA-CC0B26344A08@gmail.com>
To:     Peter Zijlstra <peterz@infradead.org>
Precedence: bulk

Just following my questions with the answers I figured out, just to save
others time.

On Sep 20, 2022, at 9:48 AM, Nadav Amit <nadav.amit@gmail.com> wrote:

> On Sep 20, 2022, at 4:02 AM, Peter Zijlstra <peterz@infradead.org> =
wrote:
>=20
>> On Mon, Sep 19, 2022 at 07:35:42PM -0700, Nadav Amit wrote:
>>=20
>>> 1. What is the reason that inline functions are marked with notrace?
>>=20
>> IIRC the concern is that a notrace function using an inline function;
>> GCC deciding to not inline and then still hitting tracing.
>>=20
>> For noinstr we've mandated __always_inline to avoid this problem. The
>> direct advantage is that those inlined into instrumented code get, =
well,
>> instrumented.

Commit 45959ee7aa645 (=E2=80=9Cftrace: Do not function trace inlined =
functions=E2=80=9D)
gives two reasons which correspond with what you were saying: (1)
consistency and (2) function that should not be traced are mostly marked =
as
inline.

I am not sure I fully agree with the arguments, specifically the =
consistency
(any function might be inlined and not traceable). But I am too =
afraid/lazy
to cause damage and fix it. I will remove the inline and play a bit with =
the
kernel to see how it behaves.

>>> 2. Is probing function that is called from do_idle() supposed to =
work, or
>>>  should the kernel prevent it?
>>=20
>> Should work for some :-) Specifically it doesn't work for those that
>> disable RCU, and that's (largely) being fixed here:
>>=20
>> =
https://lore.kernel.org/all/20220919095939.761690562@infradead.org/T/#u
>>=20
>> Although looking at it just now, I think I missed a spot.. lemme go =
fix
>> ;-)

I did not try your patches, but I do think I figured out what=E2=80=99s =
wrong and
sent a patch.

=
https://lore.kernel.org/lkml/EECE6FD7-FC3D-40E2-A957-151A1BE2B2F9@vmware.c=
om/T/#t

Thanks again,
Nadav=