Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Sep 2022 05:54:15 +0200
From:   Oscar Salvador <osalvador@suse.de>
To:     Mike Kravetz <mike.kravetz@oracle.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Muchun Song <songmuchun@bytedance.com>,
        Joao Martins <joao.m.martins@oracle.com>,
        Matthew Wilcox <willy@infradead.org>,
        Michal Hocko <mhocko@suse.com>, Peter Xu <peterx@redhat.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Vlastimil Babka <vbabka@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] hugetlb: freeze allocated pages before creating
 hugetlb pages
Message-ID: <YyqK51L65yS4OKye@localhost.localdomain>
References: <20220916214638.155744-1-mike.kravetz@oracle.com>
 <Yyk7cN8KhUlNFmM8@localhost.localdomain>
 <Yyn0BZu1gNHG7pZ7@monkey>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yyn0BZu1gNHG7pZ7@monkey>
Precedence: bulk

On Tue, Sep 20, 2022 at 10:10:29AM -0700, Mike Kravetz wrote:
> Hi Oscar, thanks for taking a look.
> 
> I think you may have missed something in the above comment.  For gigantic
> pages, we only freeze pages if NOT demote.  In the demote case, pages are
> already frozen.

Yeah.
It got me confused that the link you posted
(https://lore.kernel.org/linux-mm/20210622021423.154662-3-mike.kravetz@oracle.com/)
seemed like an earlier version of what it got into upstream,
and in there there was "demotion" handling.

Having checked the tree it all looks sound.

I will wait for v3.

Thanks Mike!


-- 
Oscar Salvador
SUSE Labs