Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: VzRL0tuMBUWrhlTuLkBOmqvyNYkH4SaMeTlxDELp+eedS+sLacUhwcrjJ/umB5m6JQIxkEDec6
 C5NS77kY7BIkClwcu70lUMMolbanyg9RvOUpjnuCjMxrIJ9DmUV/UYM+8iE4sJxOG8M2ckR/PM
 PP87AvS4/wNGSXxzzSeqrA+/m78o7zEqKmMrjem4IFWLPbpuoaVvvnrqVkuZkVnBCPxeQL6X9B
 5Gxua8CYN4Qk1lFWzpz6+fEMFpEQYQhCQmzEgIqOKSAayT9HbX6Ea78uhZhCa616t1udXY3oln
 vy0l6ZqYu3GoE1o9oTHkahu7
IronPort-SDR: oDy0vGRCB1K7P6GIDzgfU0NqF1q9kyJlrGBnLvft8g6r0Z5Y9iaBdhsI99agfqVyX2S8bX0UXM
 D6BtI1O+AffzHsbCJrkzlLDfLnBcPYv/5kTi6r9CAqeReXo1FU5HNzmdi0OkAIlPIJfn934Jcw
 WPuAoh5Sl1gylrl6FhKPvLtvqaX//sGsvU78c58mYUhJj1Ix4EcSodtVIEtiIpMlRitTA9pW3K
 sqvpiuEGlEWGY0vBaTQiG+cFC9ncQA088Ng0LCJnbETR1H+ABt4lkN1ePl7cxdEJ+AAoNlqqBA
 7fg=
WDCIronportException: Internal
Message-ID: <a5b8d028-41a2-6a77-817b-37d9d7424594@opensource.wdc.com>
Date:   Wed, 21 Sep 2022 13:39:13 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH linux-next] ata: libata-eh: Remove the unneeded result
 variable
Content-Language: en-US
To:     cgel.zte@gmail.com
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        ye xingchen <ye.xingchen@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220920062929.214976-1-ye.xingchen@zte.com.cn>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220920062929.214976-1-ye.xingchen@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/20/22 15:29, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Return the value ata_port_abort() directly instead of storing it in
> another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Applied to for-6.1. Thanks !

> ---
>   drivers/ata/libata-eh.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index 7c128c89b454..7dbca2a2f9ee 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -1086,14 +1086,11 @@ static void __ata_port_freeze(struct ata_port *ap)
>    */
>   int ata_port_freeze(struct ata_port *ap)
>   {
> -	int nr_aborted;
> -
>   	WARN_ON(!ap->ops->error_handler);
>   
>   	__ata_port_freeze(ap);
> -	nr_aborted = ata_port_abort(ap);
>   
> -	return nr_aborted;
> +	return ata_port_abort(ap);
>   }
>   EXPORT_SYMBOL_GPL(ata_port_freeze);
>   

-- 
Damien Le Moal
Western Digital Research