Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2073b6bd-a4bd-4ab5-300d-2ce989e25d5f@linaro.org>
Date:   Wed, 21 Sep 2022 08:22:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH v9,2/7] dt-bindings: thermal: Add dt-binding document for
 LVTS thermal controllers
Content-Language: en-US
To:     Balsam CHIHI <bchihi@baylibre.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     rafael@kernel.org, rui.zhang@intel.com, daniel.lezcano@linaro.org,
        amitk@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, khilman@baylibre.com,
        mka@chromium.org, robh+dt@kernel.org, krzk+dt@kernel.org,
        matthias.bgg@gmail.com, p.zabel@pengutronix.de,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, james.lo@mediatek.com,
        fan.chen@mediatek.com, louis.yu@mediatek.com,
        rex-bc.chen@mediatek.com, abailon@baylibre.com
References: <20220817080757.352021-1-bchihi@baylibre.com>
 <20220817080757.352021-3-bchihi@baylibre.com>
 <716d6471-f0e2-489e-5f9e-9e38e9e7953a@collabora.com>
 <CAGuA+orxfcycwcUMpLe+dkjnXPQkELQsz0vBggGKTQ04XRGc+g@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <CAGuA+orxfcycwcUMpLe+dkjnXPQkELQsz0vBggGKTQ04XRGc+g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 14/09/2022 16:01, Balsam CHIHI wrote:
> Hi Angelo,
> 
> I've got the following errors after implementing these changes :
> [...]
>   nvmem-cells:
>     minItems: 1
>     description: Calibration eFuse data for LVTS
> 
>   nvmem-cell-names:
>     minItems: 1
>     items:
>       pattern: 'lvts-calib-data[0-9]+$'
> 
>   "#thermal-sensor-cells":
>     const: 1
> 
> allOf:
>   - $ref: thermal-sensor.yaml#
> 
>   - if:
>       properties:
>         compatible:
>           contains:
>             enum:
>               - mediatek,mt8192-lvts-ap
>               - mediatek,mt8192-lvts-mcu
>     then:
>       properties:
>         nvmem-cells:
>           maxItems: 1
> 
>         nvmem-cell-names:
>           maxItems: 1
> 
>   - if:
>       properties:
>         compatible:
>           contains:
>             enum:
>               - mediatek,mt8195-lvts-ap
>               - mediatek,mt8195-lvts-mcu
>     then:
>       properties:
>         nvmem-cells:
>           maxItems: 2
> 
>         nvmem-cell-names:
>           maxItems: 2
> [...]
> 
> $ make DT_CHECKER_FLAGS=-m dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
>   LINT    Documentation/devicetree/bindings
>   CHKDT   Documentation/devicetree/bindings/processed-schema.json
> /home/balsam/src/linux-mtk-lvts-newThermalOF/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml:
> properties:nvmem-cell-names:items: {'pattern':
> 'lvts-calib-data[0-9]+$'} is not of type 'array'
> from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> /home/balsam/src/linux-mtk-lvts-newThermalOF/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml:
> ignoring, error in schema: properties: nvmem-cell-names: items
>   DTEX    Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dts
>   DTC     Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb
>   CHECK   Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb
> Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb:0:0:
> /example-0/soc/thermal-sensor@1100b000: failed to match any schema
> with compatible: ['mediatek,mt8192-lvts-ap']
> 
> am I missing something?

Maybe maxItems: 2 in top-level property?


Best regards,
Krzysztof