Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Divya.Koppera@microchip.com>
To:     <michael@walle.cc>, <andrew@lunn.ch>, <hkallweit1@gmail.com>,
        <linux@armlinux.org.uk>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <Horatiu.Vultur@microchip.com>
Subject: RE: [PATCH net] net: phy: micrel: fix shared interrupt on LAN8814
Thread-Topic: [PATCH net] net: phy: micrel: fix shared interrupt on LAN8814
Thread-Index: AQHYzPue4/MKFNRLiU2mnzSUPXO8m63pcdJw
Date:   Wed, 21 Sep 2022 06:49:04 +0000
Message-ID: <CO1PR11MB47714260208C48DDCF5855CEE24F9@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20220920141619.808117-1-michael@walle.cc>
In-Reply-To: <20220920141619.808117-1-michael@walle.cc>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sS0BhfgwxkrIXiax0Zw1CZa/Ud49u7eokfx8a8/mIoYuO+Oey+i5W5c6Jn0+?=
 =?us-ascii?Q?a0i/nQ+9H4R+aaBJ7pjvhBj5NmkAmk9EX2UO8sdR50o22XrrwfmpC5fvTCut?=
 =?us-ascii?Q?YkpTEYXHCe+2BG1jm0dU9Gu1VyN5fMM0Al1UxyiMNQxBHua+l8WYxyDPzvRd?=
 =?us-ascii?Q?l9n16PRxNOvAZXP8800RKJZ8/7+c7IXrelEYUMA0CweYchg5kKKVj9UsxKzC?=
 =?us-ascii?Q?OYt8dFgpRh5VdgXf+Y9gKUAm/Bbo6ZeGZcS2IQbLzvB0dm3Nz4IuhSlNGii/?=
 =?us-ascii?Q?bPRvA1hrJgLQTJI7m3BU0u6gbezDQtgyghj9Q0/FlfvCgtpzIHG3eUlUSQTE?=
 =?us-ascii?Q?IUWSq7X0fJe+3p510JAQbCUPsxPfsZCAt/MZ3MXeYiukEz0r2hLZVCCuA0Eu?=
 =?us-ascii?Q?1gsqDfitPF9C2qESiqT4GmvyFbedSXjdGBValAcpAgpd9yGsY/JmDnKkpGcX?=
 =?us-ascii?Q?YYtOLoH20gncArHkOtBpV9AlCevvPwNsXRo+GYfAfa32x8/rBiDZYc0bZ/Qk?=
 =?us-ascii?Q?aeMUU/jZcTl1ox1LhmFNuCBhDOac8bHuxzWNcGYTZMlko0/BGtcU796ZAM6l?=
 =?us-ascii?Q?7Vcbj9lOyj000KjCSNSlsNO/P2quPA+z4CcHE28o6xdREZLXUZSyqUbtKfbb?=
 =?us-ascii?Q?nykTlbuIICv1ArmT6QYKwycCSMXxdHdaezJabx0FdlmIK6A77iv1whDl+iOm?=
 =?us-ascii?Q?E2B0XneOkJJ4pG83s+TFT3pe7ktZ8lGli3L9TCv7wsqntCFRKrOUd9ZHuVON?=
 =?us-ascii?Q?3mEgG9ruZjx5/zxdBSZ2OzGupon4crKNR/S+FTOMZDQFfDtf2KQwL+Y2gbEs?=
 =?us-ascii?Q?uFfDIJfB/g+9zWI3dLo1KvSTqKF+I1gPetRQ3CpAiki5I2It3uZa325JzENK?=
 =?us-ascii?Q?Xa8WLdP1viZYDQH/1nTtQ72eJFaAIp3tPk7Te++vt0sl9/vLBCotn+CQQ75q?=
 =?us-ascii?Q?D/ikIz79CYK0AEECX9OcAMSNgXPC6KkaHYVGSorqNMKqd8/zluHAnizp7Xle?=
 =?us-ascii?Q?3ts9gnj03tyW0G2wJvww+GznAFPvjx/Xu1Ei+1WH/CCsSOXZSzzV+TRx4Bb4?=
 =?us-ascii?Q?T9ZIpSR95KM202n/qGe+2a2pcB8PGdp4oXpRZcl9ie4VATV6ykGR6XiUxJNM?=
 =?us-ascii?Q?wsEp6KjkIEE2m6W3ZZHm3jzobL5bTAtgm4N7ik4rxKb13WcVcovQxEbhKyNQ?=
 =?us-ascii?Q?mnXfetAAq0uNhN1w8+R3T0Pt+Yu9rrHApawU88DFfPfmfh6gIx1YCw90N8QS?=
 =?us-ascii?Q?o3fDJbGjQ01i7rvncqpX/WOBE3q8VmJauNORd5LVjVIsQQY96ELnlwqqNJSW?=
 =?us-ascii?Q?9DN0TJAkSjC8m8EkxVhBIpIPxoeNpOn98uewO//Oeky+V8KB8GU2y1+SdF4g?=
 =?us-ascii?Q?jye+aAXCMkG1KBUsNiOG0/Pg7nkWOk+DJrTxxFYBUgOmSmihQQ0bTf2OAtya?=
 =?us-ascii?Q?7EwHA4zypMipY2+tAWFBXhtmOTH5xD+sVPw5VFPO8OXu5Dv5J+rxaTKz2MM9?=
 =?us-ascii?Q?HcnQAYeGFI5uAfyVPhfZbwc0qS8krEdC8xqs+HnuLdiyvp9HQAhCHP6zE5U9?=
 =?us-ascii?Q?W5z8l9qfj3P2Ws5nypfPb0AktmzyOmlnSGXnouhPFwFzXdXFgwwGqVwjt5+3?=
 =?us-ascii?Q?cw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c3d3519-32b9-49dc-67fe-08da9b9d5fc2
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 06:49:04.4468
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 38Cofb6I2tIpYC9/s1MEhvyiwNG+fxmjZPNvqzQ091YcD+09s6p3ghO6SzVSZfmuUQeaEKr/rUtc286oZxp9dyG7M2IPmGBUW6iQ6uzRKo4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5614
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Tuesday, September 20, 2022 7:46 PM
> To: Andrew Lunn <andrew@lunn.ch>; Heiner Kallweit
> <hkallweit1@gmail.com>; Russell King <linux@armlinux.org.uk>; David S .
> Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>;
> Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Cc: Divya Koppera - I30481 <Divya.Koppera@microchip.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Horatiu Vultur -
> M31836 <Horatiu.Vultur@microchip.com>; Michael Walle
> <michael@walle.cc>
> Subject: [PATCH net] net: phy: micrel: fix shared interrupt on LAN8814
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> Since commit ece19502834d ("net: phy: micrel: 1588 support for LAN8814
> phy") the handler always returns IRQ_HANDLED, except in an error case.
> Before that commit, the interrupt status register was checked and if it w=
as
> empty, IRQ_NONE was returned. Restore that behavior to play nice with the
> interrupt line being shared with others.
>=20
> Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  drivers/net/phy/micrel.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index
> 98e9bc101d96..21b6facf6e76 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -2732,16 +2732,19 @@ static int lan8804_config_intr(struct phy_device
> *phydev)  static irqreturn_t lan8814_handle_interrupt(struct phy_device
> *phydev)  {
>         int irq_status, tsu_irq_status;
> +       int ret =3D IRQ_NONE;
>=20
>         irq_status =3D phy_read(phydev, LAN8814_INTS);
> -       if (irq_status > 0 && (irq_status & LAN8814_INT_LINK))
> -               phy_trigger_machine(phydev);
> -
>         if (irq_status < 0) {
>                 phy_error(phydev);
>                 return IRQ_NONE;
>         }
>=20
> +       if (irq_status & LAN8814_INT_LINK) {
> +               phy_trigger_machine(phydev);
> +               ret =3D IRQ_HANDLED;
> +       }
> +
>         while (1) {
>                 tsu_irq_status =3D lanphy_read_page_reg(phydev, 4,
>                                                       LAN8814_INTR_STS_RE=
G); @@ -2750,12 +2753,15
> @@ static irqreturn_t lan8814_handle_interrupt(struct phy_device *phydev)
>                     (tsu_irq_status & (LAN8814_INTR_STS_REG_1588_TSU0_ |
>                                        LAN8814_INTR_STS_REG_1588_TSU1_ |
>                                        LAN8814_INTR_STS_REG_1588_TSU2_ |
> -                                      LAN8814_INTR_STS_REG_1588_TSU3_)))
> +
> + LAN8814_INTR_STS_REG_1588_TSU3_))) {
>                         lan8814_handle_ptp_interrupt(phydev);
> -               else
> +                       ret =3D IRQ_HANDLED;
> +               } else {
>                         break;
> +               }
>         }
> -       return IRQ_HANDLED;
> +
> +       return ret;
>  }
>=20
>  static int lan8814_ack_interrupt(struct phy_device *phydev)
> --
> 2.30.2

Reviewed-by: Divya Koppera <Divya.Koppera@microchip.com>