Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fb901889-d769-ba56-d4cb-2d9d8b50f74f@linaro.org>
Date:   Wed, 21 Sep 2022 09:05:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH v2 2/3] dt-bindings: thermal: Convert loongson2 to
 json-schema
Content-Language: en-US
To:     Yinbo Zhu <zhuyinbo@loongson.cn>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     zhanghongchen <zhanghongchen@loongson.cn>
References: <20220921015605.17078-1-zhuyinbo@loongson.cn>
 <20220921015605.17078-2-zhuyinbo@loongson.cn>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220921015605.17078-2-zhuyinbo@loongson.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/09/2022 03:56, Yinbo Zhu wrote:
> Convert the loongson2 thermal binding to DT schema format using
> json-schema.

Incorrect subject and incorrect commit msg. There is no conversion here.

> 
> Signed-off-by: Yinbo Zhu <c>
> ---
> Change in v2:
> 		1. Add description and type about the "id".	
> 		2. Make the filename was based on compatible.
> 
>  .../bindings/thermal/loongson2-thermal.yaml   | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml
> 
> diff --git a/Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml
> new file mode 100644
> index 000000000000..2994ae3a56aa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/loongson2-thermal.yaml


No improvements here. You ignore my comments, so I am going to NAK it.


> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/loongson2-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Thermal sensors on loongson2 SoCs
> +
> +maintainers:
> +  - zhanghongchen <zhanghongchen@loongson.cn>
> +  - Yinbo Zhu <zhuyinbo@loongson.cn>
> +
> +properties:
> +  compatible:
> +    const: loongson,loongson2-thermal
> +
> +  reg:
> +    maxItems: 1
> +
> +  id:
> +    $ref: '//schemas/types.yaml#/definitions/uint32'

No improvements here, so let me be specific - you need to really justify
such property or it cannot go to schema.

> +    description: |
> +      Specify the thermal sensor id.
> +    minimum: 0
> +    maximum: 3
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  "#thermal-sensor-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - id
> +  - interrupt-parent

Why?

> +  - interrupts
> +  - '#thermal-sensor-cells'

Use the same style of quote: ' or ".

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    thermal: thermal@1fe01500 {

How other similar nodes are named (in other DTS files)?


Best regards,
Krzysztof