Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220917022602.3843619-1-floridsleeves@gmail.com>
 <20220920113744.64b16924@kernel.org> <CAMEuxRq3YDsCVBrdP78HnPeL7UcFiLWwKt6mEB2D+EVeSWG+pw@mail.gmail.com>
 <20220920124148.58e8aab5@kernel.org>
In-Reply-To: <20220920124148.58e8aab5@kernel.org>
From:   Li Zhong <floridsleeves@gmail.com>
Date:   Wed, 21 Sep 2022 01:31:06 -0700
Message-ID: <CAMEuxRrRJ6RZQ5Pjoxb+5cn1Z5iKZNvZ_ydATBwB1NV5S-pEog@mail.gmail.com>
Subject: Re: [PATCH v1] net/ethtool/tunnels: check the return value of nla_nest_start()
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        pabeni@redhat.com, edumazet@google.com, davem@davemloft.net
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Sep 20, 2022 at 12:41 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 20 Sep 2022 12:31:29 -0700 Li Zhong wrote:
> > On Tue, Sep 20, 2022 at 11:37 AM Jakub Kicinski <kuba@kernel.org> wrote:
> > > On Fri, 16 Sep 2022 19:26:02 -0700 Li Zhong wrote:
> > > >                       goto err_cancel_table;
> > > >
> > > >               entry = nla_nest_start(skb, ETHTOOL_A_TUNNEL_UDP_TABLE_ENTRY);
> > > > +             if (!entry)
> > > > +                     return -EMSGSIZE;
> > >
> > > not even correct, and completely harmless
> >
> > Thanks for your reply. Maybe a more suitable way of error handling is 'goto
> > err_cancel_table;'?
>
> Yes, but you _most_ provide the detailed analysis of the impact
> in the commit message for the patches to be considered for merging.

Thanks for the suggestion. The commit message is updated with more details.