Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Sep 2022 10:34:35 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     linux-kernel@vger.kernel.org
Cc:     linux-tip-commits@vger.kernel.org,
        Jules Irenge <jbi.octave@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, x86@kernel.org
Subject: Re: [tip: perf/core] perf/core: Convert snprintf() to scnprintf()
Message-ID: <YyrMmyUPk+4t6OLm@hirez.programming.kicks-ass.net>
References: <166374773592.401.16831946846027095231.tip-bot2@tip-bot2>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <166374773592.401.16831946846027095231.tip-bot2@tip-bot2>
Precedence: bulk

On Wed, Sep 21, 2022 at 08:08:55AM -0000, tip-bot2 for Jules Irenge wrote:
> The following commit has been merged into the perf/core branch of tip:
> 
> Commit-ID:     678739d622ae7b75b62d550858b6bf104c43e2df
> Gitweb:        https://git.kernel.org/tip/678739d622ae7b75b62d550858b6bf104c43e2df
> Author:        Jules Irenge <jbi.octave@gmail.com>
> AuthorDate:    Sun, 18 Sep 2022 00:41:08 +01:00
> Committer:     Ingo Molnar <mingo@kernel.org>
> CommitterDate: Wed, 21 Sep 2022 10:01:20 +02:00
> 
> perf/core: Convert snprintf() to scnprintf()
> 
> Coccinelle reports a warning:
> 
>     WARNING: use scnprintf or sprintf
> 
> Adding to that, there has also been some slow migration from snprintf to scnprintf.
> 
> This LWN article explains the rationale for this change:
> 
>     https: //lwn.net/Articles/69419/
> 
> No change in behavior.
> 
> [ mingo: Improved the changelog. ]

And yet, at this point I still have no clue what's wrong with
snprintf(). So not much improvement :/

As such I'm still very much against this patch.