Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Hidenori Kobayashi <hidenorik@chromium.org>
Date:   Wed, 21 Sep 2022 17:27:42 +0900
To:     Sakari Ailus <sakari.ailus@iki.fi>
Cc:     Hidenori Kobayashi <hidenorik@chromium.org>,
        Dongchun Zhu <dongchun.zhu@mediatek.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: ov8856: Add runtime PM callbacks
Message-ID: <20220921082742.bhdgpxzuk32hfgvc@google.com>
References: <20220921081536.2551789-1-hidenorik@chromium.org>
 <YyrJPBXzL+MZH8az@valkosipuli.retiisi.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YyrJPBXzL+MZH8az@valkosipuli.retiisi.eu>
Precedence: bulk

Hi Sakari,

On Wed, Sep 21, 2022 at 11:20:12AM +0300, Sakari Ailus wrote:
> Hi Hidenori,
> 
> On Wed, Sep 21, 2022 at 05:15:35PM +0900, Hidenori Kobayashi wrote:
> >  
> > +static int __maybe_unused ov8856_runtime_suspend(struct device *dev)
> > +{
> > +	__ov8856_power_off(dev);
> > +
> > +	return 0;
> > +}
> > +
> > +static int __maybe_unused ov8856_runtime_resume(struct device *dev)
> > +{
> > +	return __ov8856_power_on(dev);
> > +}
> 
> These two functions are redundant now, you can call __ov8856_power_on /
> __ov8856_power_off directly. The return type of __ov8856_power_off needs to
> be changed to int. You could also remove the underscores from the names at
> the same time.

Will fix it as above. I just wasn't sure about the policy. Thanks!

Best regards,
Hidenori