Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH] x86/mm: disable instrumentations of mm/pgprot.c
Thread-Topic: [PATCH] x86/mm: disable instrumentations of mm/pgprot.c
Thread-Index: AQHYzZh/CXtSwfb9LkuupZiXt0U5TA==
Date:   Wed, 21 Sep 2022 08:59:46 +0000
Message-ID: <YyrSgXltQr5XrnSN@x1-carbon>
References: <20220824084726.2174758-1-naohiro.aota@wdc.com>
In-Reply-To: <20220824084726.2174758-1-naohiro.aota@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ih7ZA5QN5gufNjci3pCwQK2Nhyp7LTIZoK0JhYwVBM1wL0UxobUqOorYEDTx?=
 =?us-ascii?Q?ClI9iP6vlPNQmu/wDVg6Ie9UqZf4+BOCNkNM98vx1d9QA6CNGcBlRAjat3FZ?=
 =?us-ascii?Q?psPXJLuuwUX3LPqsBwz3Yi8PQLyNzLFag/wD/xm7S64yDbmMZK5cClI+KRit?=
 =?us-ascii?Q?y7i4y4b/FfMi2byqsmFj7TBwm5cq0Gnyqqco4tpBwRmV9DGDTgO7ygI5tsIr?=
 =?us-ascii?Q?6+j14XRtJYhhsNiWiTInu2K7v7udA0QgFTAQ9/2POyUpF1Nci58fbm7TIj9J?=
 =?us-ascii?Q?KYl7x2xBQF4/6hCIX//hjC7EMO2z7UDBc3YTY1T/BmnKrGUfs+QOb0SjTe6Z?=
 =?us-ascii?Q?UTR5HOuWqYlJh2DFEKvffzbNtW4gE0crFrtZ/18rNUg1ozPQt2JSRxOqbOb0?=
 =?us-ascii?Q?6AltditZCT5KfLgzG24ve1uHmuihotUxVD5Lb23Uq7hZWkTpX8cJfAGDhKoo?=
 =?us-ascii?Q?+waYXjaX8CdJSh1wklJKIgjbAnwVx9MDH33Z7m59YD4iYN284NcoJTsNSLwF?=
 =?us-ascii?Q?y0r9CexHymnE6l3T8lP394rl5PBoy5MQze3gBow5TAyyug/UZbNV0jLhLuUp?=
 =?us-ascii?Q?7s0rudUvnKg5GHQV93i2tdvFYGXqBtDHa6wx+e+osTags2xsrJIRUiPFI0+C?=
 =?us-ascii?Q?coHgHBxihqucGrjcdgzEuebBndoafiFnx9uZgwuMp62pjg28c0L0NQgYv8ER?=
 =?us-ascii?Q?3KrPk7iUBV07Ygm0lmctPn8ew7mfBIItVIRU4Nf8sz91xVX6WgBZqMNgfvIp?=
 =?us-ascii?Q?avl84PwA9/zmGw5Q0q77fSgSIysozTvWRT8iQDlYO+ZDG6uCVRfDducBiHLv?=
 =?us-ascii?Q?5JwZq6RIh29/UkL9u3XTT8jX92Hryf1UWRQ31qd9wW9qdYwZm+TWx64V4Fie?=
 =?us-ascii?Q?4qxTAPQvyaX2QX8ULLv1/cr81ffZGQCH3Yrlvcz+04kOk7QbPd6Ra7JRXpOS?=
 =?us-ascii?Q?NV3+VPAb6xSOmKGMAis+FsZPJkukRFq1xn+n6W/GA18aUATywQugRUXkns4/?=
 =?us-ascii?Q?/mZojpi6BpyhBQiqZKpZM2pQrPxu++s5x01Xn5PDpyATzRRrYuy/qkM8/ZEP?=
 =?us-ascii?Q?AS/vj13XeBV+/Ntr1RqIml06DKEYtUm6gcpSQl4Z2btwOcNAHpdy5shIA9/f?=
 =?us-ascii?Q?XSYwA89sIAPwywRmhkwjnorUuxQfpVRA0BEUjTZUI7bxQFoFS7orRua5IIsj?=
 =?us-ascii?Q?MG8SaA67g+72NG4UpPzWPxca4lgKtoStuezpBUc4U8viEIAMHD/seO81BAVs?=
 =?us-ascii?Q?Scsqf1QTaJ4FcIide8edHZ6zO2kxYeBb1h7e1d/Omu06fc1humxzQbX5p23K?=
 =?us-ascii?Q?e1r13/z/kZxPKKEXi+TKLzvtd3Qew7eQJorgTlok5X5YtyGgO+hxEX+Y6X8u?=
 =?us-ascii?Q?iFrFKNCiBOeHUQoEg4YpJ6Q7yWyQ69CEc6MzSxyesNrVyWu7Rd4Cz2tMw5Tr?=
 =?us-ascii?Q?nnWnN34VdSYX9Kua+kUlC4hLxC9Wr92CU4qb12qQoNtU4Ybz21sLUIKRCu0z?=
 =?us-ascii?Q?jK3FUTMWvS4FbEuH/6dlVrbFDrOq1GLdPlg3xypxmxXwvaRVXEeHhAlTWQRk?=
 =?us-ascii?Q?pqBygSLhMvHPqojPi+JJWysQXMI71wv97IBdPf7Rfp+6lLuMIm9+6P+LmlxB?=
 =?us-ascii?Q?KA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CAC8B6DE02485047899CCFE4DC934A0F@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9bf14f1c-d1c7-4616-9839-08da9bafa1fe
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 08:59:46.5120
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: glgoDzofirJCTjNUVYELKtvvnC6Vg1/tgZkh1Hm5yZRbiov3cH5+HHhkB2wD0x6xpvbqBQ+lbHGFRhRj7z4myQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB7726
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 24, 2022 at 05:47:26PM +0900, Naohiro Aota wrote:
> The commit 4867fbbdd6b3 ("x86/mm: move protection_map[] inside the
> platform") moved accesses to protection_map[] from mem_encrypt_amd.c to
> pgprot.c. As a result, the accesses are now targets of KASAN (and other
> instrumentations), leading to the crash during the boot process.
>=20
> Disable the instrumentations for pgprot.c like commit 67bb8e999e0a
> ("x86/mm: Disable various instrumentations of mm/mem_encrypt.c and
> mm/tlb.c").
>=20
> Before this patch, my AMD machine cannot boot since v6.0-rc1 with KASAN
> enabled, without anything printed. After the change, it successfully boot=
s
> up.
>=20
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
> ---

Hello Andrew,

I see that this patch is in linux-next, but not in Linus's tree.

Since this fixes something introduced in v6.0-rc1, I think this
ought to go into v6.0 before it is released.


Kind regards,
Niklas=