Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     "S.J. Wang" <shengjiu.wang@nxp.com>,
        "andersson@kernel.org" <andersson@kernel.org>,
        "mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
        "arnaud.pouliquen@foss.st.com" <arnaud.pouliquen@foss.st.com>
CC:     "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "shengjiu.wang@gmail.com" <shengjiu.wang@gmail.com>
Subject: RE: [PATCH v2] rpmsg: char: Avoid double destroy of default endpoint
Thread-Topic: [PATCH v2] rpmsg: char: Avoid double destroy of default endpoint
Thread-Index: AQHYzWBVgQ3cpYwrCEyw4uFZoIRr1a3pipYQ
Date:   Wed, 21 Sep 2022 08:18:45 +0000
Message-ID: <DU0PR04MB941748A5EF06062B66547D8B884F9@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <1663725523-6514-1-git-send-email-shengjiu.wang@nxp.com>
In-Reply-To: <1663725523-6514-1-git-send-email-shengjiu.wang@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kOHFt4EGrC7gD511KETxEfilq3Au68VqSAYJiS0i7t7Wi8zgjqA2sQ6WyPG/?=
 =?us-ascii?Q?ZwwmuNK2YEwdiV7kZPIoxqbTCwzEHl0w6UvA7PPCPP1iIVmwfGiXVvO17UvI?=
 =?us-ascii?Q?92tjuPXFt8GAfAK4294z6Ok9XytWeg1RPibPEF1DsQ3F8pmTf0rymgI4t2tN?=
 =?us-ascii?Q?7AlOEUBMMK6Lw88QnbeFut7iVV18AqOjskOlU6pqlnlVZ3FYJTW2jkfJ45FO?=
 =?us-ascii?Q?ZnsMpR/XC9bMzSzvM4e92Cv+t8Nn8EN2ogQdZ44GJqCUbsu+bhT7MkoDWymx?=
 =?us-ascii?Q?IAM+0+ItXbKRBeEQ/UcKLeHXNoUQJy+XQPWcChUGTQ6E/459wHqV0BYuQ1WN?=
 =?us-ascii?Q?DSu9c5evjs7bn0b2n+avDf7l/7T59oHEdtLVtNNXqI9Mz5vvuoHmRDBi7+4t?=
 =?us-ascii?Q?Eteb8V+Rmw+/46K0VcNrcNUjh19HV/og6acyk+D5xBT9lKFkAhKjVNwDjaYl?=
 =?us-ascii?Q?KEznWjiHxEVfw/ZnK5gMznPU5RCpShPpQhxb7yW2enavjI0spUsvOWVnbyId?=
 =?us-ascii?Q?Of1k1zSuZ82XMFzAM6EF1iit0ISzUSNpQ2D69YN5rjKoWqQrWKmcuVoeb11v?=
 =?us-ascii?Q?yuPdwH2qM2sIT5HFOXBILhmC4XW5Ao/pB8tBNhq3G7DGI5oPV8xLjxD2Aap/?=
 =?us-ascii?Q?HTHyZzwwnhqFZdKEB0GtACk8USDJUndNsIW833GAsIEqo37coifzyT9gev7P?=
 =?us-ascii?Q?Dk7fOvqJkQppuIJwb5T3jOsTzI/7oNSXyItGsarXRBjP57pNn9XZi3UgT55L?=
 =?us-ascii?Q?jxY76sctXPf3YiRu4W6K4rVGnQpU46EMoksc5PCz6GqpdWnWbeX++t9J0ZDL?=
 =?us-ascii?Q?WQJ8be4ql5FNfwJrPy+RonEeL5m4BU61tniB7wYprjrsLs4mYpgRsvtRkqPA?=
 =?us-ascii?Q?B4L7WB8kZfQ0xjyRcgQRYNLCQvmzXqYKosSkpz7ZYbKrK6js9Y5yUmAejMei?=
 =?us-ascii?Q?XS1KpgGOGE+Pt8XlQtNcEhzXInKpNjvNGcuGRhP1aqqhCwjpW03m4WupARHG?=
 =?us-ascii?Q?y34Snt8tLs6Bavedjb7XsoECZjiIaj43P+lQJ6svAAwoC+d05Rw71yFzAqFo?=
 =?us-ascii?Q?yAC6IcesYzzm26pcmkS1LcLflxUiQIycfzoFUdTvhLpIf199rccq9wSRseuA?=
 =?us-ascii?Q?rVDNFGf3IcrMzGzwLhXT5QaRGcDcpGwXob489j6km/kX9xe6r8uv12LcZZdU?=
 =?us-ascii?Q?f/g1qnmualyG9jIexQm7+zafwoefJpodVsDCr14BE9gLFd0FWa9lAIrD511W?=
 =?us-ascii?Q?PNU/eQb/FFIjuGrXTcUm4HCvpWp4LkXOvWX9UiWbeToUD0dwQTRnCZpMiAz+?=
 =?us-ascii?Q?0hkhcVQZ91+GGoGqRNfUIxpr+IlK14TGT+PFHsyCPl7cTc3/72aADwAGRFbq?=
 =?us-ascii?Q?+a/MpdeT7j0qm0sqd0g4ILOmYnhiMe6+mvJYMvU4TjnL7FK94MvTJ2raPsUm?=
 =?us-ascii?Q?wUTk4s1yasa4BdBhgHHUes6uQAQ3bMQStTltkalc9Y64qFIpk8PQR+K3MCM+?=
 =?us-ascii?Q?CQp7zbD2apGxR4LwZeGPVS4+TzjSCEL/WetdSzPjLSft3aGPZJg104l6Q8QA?=
 =?us-ascii?Q?RcJ+XZuOkHjjglQtIv0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bff85cb8-30c1-49c1-cd63-08da9ba9e6f2
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 08:18:45.2484
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uzOctORcuw+X+qOJ9awYm4H5RbTGXz201Z5hqsPO5GvCMKIgwSDT9o5i3jJAEX/EkzYW1lVstFgL4lP38pOl4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7617
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH v2] rpmsg: char: Avoid double destroy of default endpoint
>=20
> The rpmsg_dev_remove() in rpmsg_core is the place for releasing this
> default endpoint.
>=20
> So need to avoid destroying the default endpoint in
> rpmsg_chrdev_eptdev_destroy(), this should be the same as
> rpmsg_eptdev_release(). Otherwise there will be double destroy issue that
> ept->refcount report warning:
>=20
> refcount_t: underflow; use-after-free.
>=20
> Call trace:
>  refcount_warn_saturate+0xf8/0x150
>  virtio_rpmsg_destroy_ept+0xd4/0xec
>  rpmsg_dev_remove+0x60/0x70
>=20
> The issue can be reproduced by stopping remoteproc before closing the
> /dev/rpmsgX.
>=20
> Fixes: bea9b79c2d10 ("rpmsg: char: Add possibility to use default endpoin=
t
> of the rpmsg device")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
> ---
> changes in v2:
> - Add comments
>=20
>  drivers/rpmsg/rpmsg_char.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
> index 0850ae34fb88..3e0b8f3496ed 100644
> --- a/drivers/rpmsg/rpmsg_char.c
> +++ b/drivers/rpmsg/rpmsg_char.c
> @@ -76,7 +76,9 @@ int rpmsg_chrdev_eptdev_destroy(struct device *dev,
> void *data)
>=20
>  	mutex_lock(&eptdev->ept_lock);
>  	if (eptdev->ept) {
> -		rpmsg_destroy_ept(eptdev->ept);
> +		/* The default endpoint is released by the rpmsg core */
> +		if (!eptdev->default_ept)
> +			rpmsg_destroy_ept(eptdev->ept);
>  		eptdev->ept =3D NULL;
>  	}
>  	mutex_unlock(&eptdev->ept_lock);
> --

Reviewed-by: Peng Fan <peng.fan@nxp.com>