Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Sep 2022 10:25:23 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Cc:     anil.s.keshavamurthy@intel.com, borntraeger@linux.ibm.com,
        catalin.marinas@arm.com, dave.hansen@linux.intel.com,
        gor@linux.ibm.com, guoren@kernel.org, hca@linux.ibm.com,
        hpa@zytor.com, linux-arm-kernel@lists.infradead.org,
        linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org,
        linux-s390@vger.kernel.org, mark.rutland@arm.com,
        mhiramat@kernel.org, namit@vmware.com, palmer@dabbelt.com,
        paul.walmsley@sifive.com, x86@kernel.org,
        Yipeng Zou <zouyipeng@huawei.com>, chris.zjh@huawei.com,
        liaochang1@huawei.com
Subject: Re: [PATCH 0/2] make weak attributes in {k,u}probes
Message-ID: <YyrKc/tpLllEBH/m@hirez.programming.kicks-ass.net>
References: <20220917015522.44583-1-zouyipeng@huawei.com>
 <1663692878.h3l8c563n8.naveen@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1663692878.h3l8c563n8.naveen@linux.ibm.com>
Precedence: bulk

On Tue, Sep 20, 2022 at 10:32:46PM +0530, Naveen N. Rao wrote:
> Yipeng Zou wrote:
> > We have some function implementation under some arch does nothing.
> > We can mark it with weak attributes to improve.
> 
> That's not always an improvement. See [1] for an example, among many other
> patches to reduce use of __weak functions in the kernel.

More weak 'fun':

  https://lkml.kernel.org/r/20220419203807.655552918@infradead.org