Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754998AbXFTXNX (ORCPT ); Wed, 20 Jun 2007 19:13:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752992AbXFTXNL (ORCPT ); Wed, 20 Jun 2007 19:13:11 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:45583 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753021AbXFTXNJ (ORCPT ); Wed, 20 Jun 2007 19:13:09 -0400 Message-ID: <4679B476.9060503@garzik.org> Date: Wed, 20 Jun 2007 19:12:54 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Jay Vosburgh CC: Stephen Hemminger , "David S. Miller" , Dan Aloni , Chad Tindel , Kenji Kaneshige , netdev@vger.kernel.org, linux-kernel , Andrew Morton , bonding-devel@lists.sourceforge.net Subject: Re: [PATCH] bonding: Fix use after free in unregister path References: <1178862045.3979.33.camel@kane-linux> <20070511092519.1f34ab34@freepuppy> <1179130660.3881.23.camel@kane-linux> <20070514085840.17a343f7@freepuppy> <20070613094521.GA8860@localdomain> <20070613155335.47111c67@localhost> <15712.1181795790@death> <20070619082302.4b9a5c27@localhost.localdomain> <467817CE.80904@garzik.org> <24302.1182276732@death> In-Reply-To: <24302.1182276732@death> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 936 Lines: 22 Jay Vosburgh wrote: > The following patch (based on a patch from Stephen Hemminger > ) removes use after free conditions in > the unregister path for the bonding master. Without this patch, an > operation of the form "echo -bond0 > /sys/class/net/bonding_masters" > would trigger a NULL pointer dereference in sysfs. I was not able to > induce the failure with the non-sysfs code path, but for consistency I > updated that code as well. > > I also did some testing of the bonding /proc file being open > while the bond is being deleted, and didn't see any problems there. > > Signed-off-by: Jay Vosburgh applied to #upstream-fixes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/