Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp5070118rwb; Wed, 21 Sep 2022 02:46:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4gQzmNe+1IH6+NivRf4EZCiLy22CWHAPRPQ/l1j9S+BtV/NPmtIfc3GWk2RCAsJsSkNENt X-Received: by 2002:a17:903:11cf:b0:178:a8f4:d511 with SMTP id q15-20020a17090311cf00b00178a8f4d511mr3895606plh.72.1663753584658; Wed, 21 Sep 2022 02:46:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663753584; cv=none; d=google.com; s=arc-20160816; b=IF58aule+aFNNYe0i7NM9w4i59brWMU72T1arNu6RBKGe/I7LopzMrlyqSB336KoCh VsBoE7HvfPYhM1C3qOCV8ZzZ8njykFZMXzGAmhb1WuscgtKX+2uJYSvF2yYZcjfikBzf Rmco27fDOBte6BYcTqHeNpy/5zc609I8R7h8ycgMJ5/usO6cUObsWHaOVo/7cxEcmDWv H+RZE65J6gQm4Fx6A7xAdWJF3/YBk4PPuE8WXoPEsz9aRMmGzw2oxsiozOlVBHJ5epNI hq+4yJEsf0F7isi2nO4c9cFq1cPQ8XNifR6yZ5YQ57EUAd+F38jitL4gYYqEfHk/oqyT a76w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Ntb22kpKp0GRP270w9y5jISyAl1peCNHZAjVVQ6pW8A=; b=Q1D6bW8QENUq1sAokEUD/tRU4Sn9zUUOJ0WfdMEniBGLoV90HpLeabEOc6/xKQxMRo KES9Fk6BN7hnEF8Q8cM7noFxRtlBbc7kSfmyulSuf6kjGELuvgYNFJU9oFzeVAG3cF6H xV3Ly54njRCTNEL+GNvx+gx2uWcvBcZNL1FyhESo1V5LqK0GCAdkl+4ti0SVa4TI/TbA bKjKE+ggJ/Dr8c3VdX5du7Q/aHsJ1pRpMzubhSmDsi6GziUA57osj8ZAzd9r3npkkbXk J3G4fn4eMaDuwgBPwsC+nhoxvA4QuFRmhnqZlh3sAWiOkGNIdz2/nSzsUTikkPfGZBqq G8rA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g28-20020aa79f1c000000b00537a0e16156si2198848pfr.197.2022.09.21.02.46.12; Wed, 21 Sep 2022 02:46:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231629AbiIUJm0 (ORCPT + 99 others); Wed, 21 Sep 2022 05:42:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230144AbiIUJmY (ORCPT ); Wed, 21 Sep 2022 05:42:24 -0400 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FDB78275E; Wed, 21 Sep 2022 02:42:23 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4MXYLG6L70z6T2Zg; Wed, 21 Sep 2022 17:40:22 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.127.227]) by APP2 (Coremail) with SMTP id Syh0CgA3inN73CpjFoetBA--.3521S4; Wed, 21 Sep 2022 17:42:21 +0800 (CST) From: Yu Kuai To: tj@kernel.org, axboe@kernel.dk Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com Subject: [PATCH 0/2] blk-throttle: improve bypassing bios checkings Date: Wed, 21 Sep 2022 17:53:07 +0800 Message-Id: <20220921095309.1481289-1-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: Syh0CgA3inN73CpjFoetBA--.3521S4 X-Coremail-Antispam: 1UD129KBjvdXoWrZryfuFWfXFWrZr17ur1ftFb_yoWDJwbE9F WxJFW5JwnxX3W8JFW0yF1rXrZIgw4UWrW8Z3Z0vrW7Xrn7Zr1DKFZrJr4aqFy7ZF4kKrn8 Kr40va18CF1YvjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbz8FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCF04k20xvY0x0EwIxG rwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4 vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IY x2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26c xKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x02 67AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUoOJ5UUUUU X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yu Kuai Currently, "tg->has_rules" and "tg->flags & THROTL_TG_HAS_IOPS_LIMIT" both try to bypass bios that don't need to be throttled, however, they are a little redundant and both not perfect: 1) "tg->has_rules" only distinguish read and write, but not iops and bps limit. 2) "tg->flags & THROTL_TG_HAS_IOPS_LIMIT" only check if iops limit exist, read and write is not distinguished, and bps limit is not checked. With this patchset, biowon't be bypassedd if: 1) Bio is read/write, and corresponding read/write iops limit exist. 2) If corresponding iops limit doesn't exist, corresponding bps limit exist and bio is not throttled before. Yu Kuai (2): blk-throttle: remove THROTL_TG_HAS_IOPS_LIMIT blk-throttle: improve bypassing bios checkings block/blk-throttle.c | 21 +++++++-------------- block/blk-throttle.h | 28 +++++++++++++++++++--------- 2 files changed, 26 insertions(+), 23 deletions(-) -- 2.31.1