Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ad42d19d-959c-61b4-8581-02ce0990c23f@arm.com>
Date:   Wed, 21 Sep 2022 10:44:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] lib/vdso: use "grep -E" instead of "egrep"
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc:     Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
References: <20220920170633.3133829-1-gregkh@linuxfoundation.org>
From:   Vincenzo Frascino <vincenzo.frascino@arm.com>
In-Reply-To: <20220920170633.3133829-1-gregkh@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/20/22 18:06, Greg Kroah-Hartman wrote:
> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> 	egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the vdso Makefile to use "grep -E" instead.
> 
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>

> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  lib/vdso/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vdso/Makefile b/lib/vdso/Makefile
> index c415a685d61b..e814061d6aa0 100644
> --- a/lib/vdso/Makefile
> +++ b/lib/vdso/Makefile
> @@ -17,6 +17,6 @@ $(error ARCH_REL_TYPE_ABS is not set)
>  endif
>  
>  quiet_cmd_vdso_check = VDSOCHK $@
> -      cmd_vdso_check = if $(OBJDUMP) -R $@ | egrep -h "$(ARCH_REL_TYPE_ABS)"; \
> +      cmd_vdso_check = if $(OBJDUMP) -R $@ | grep -E -h "$(ARCH_REL_TYPE_ABS)"; \
>  		       then (echo >&2 "$@: dynamic relocations are not supported"; \
>  			     rm -f $@; /bin/false); fi

-- 
Regards,
Vincenzo