Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220817080757.352021-1-bchihi@baylibre.com> <20220817080757.352021-3-bchihi@baylibre.com>
 <716d6471-f0e2-489e-5f9e-9e38e9e7953a@collabora.com> <CAGuA+orxfcycwcUMpLe+dkjnXPQkELQsz0vBggGKTQ04XRGc+g@mail.gmail.com>
 <2073b6bd-a4bd-4ab5-300d-2ce989e25d5f@linaro.org>
In-Reply-To: <2073b6bd-a4bd-4ab5-300d-2ce989e25d5f@linaro.org>
From:   Balsam CHIHI <bchihi@baylibre.com>
Date:   Wed, 21 Sep 2022 11:44:29 +0200
Message-ID: <CAGuA+or40GSH2QvVw033+KsGC-B9D6nRYj8zXvTs91iNDqgr8Q@mail.gmail.com>
Subject: Re: [PATCH v9,2/7] dt-bindings: thermal: Add dt-binding document for
 LVTS thermal controllers
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, rafael@kernel.org,
        rui.zhang@intel.com, daniel.lezcano@linaro.org, amitk@kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        khilman@baylibre.com, mka@chromium.org, robh+dt@kernel.org,
        krzk+dt@kernel.org, matthias.bgg@gmail.com, p.zabel@pengutronix.de,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, james.lo@mediatek.com,
        fan.chen@mediatek.com, louis.yu@mediatek.com,
        rex-bc.chen@mediatek.com, abailon@baylibre.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Krzysztof, Angelo,

Thank you for the suggestions.

I tested this (below) and it worked without any problem.
"make DT_CHECKER_FLAGS=-m dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml"
"make dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml"
Should I keep it like this and submit it in v10?

[...]
nvmem-cells:
  minItems: 1
  items:
    - description: Calibration eFuse data 1 for LVTS
    - description: Calibration eFuse data 2 for LVTS

nvmem-cell-names:
  minItems: 1
  items:
    - const: lvts-calib-data-1
    - const: lvts-calib-data-2

"#thermal-sensor-cells":
  const: 1

allOf:
  - $ref: thermal-sensor.yaml#

- if:
  properties:
    compatible:
      contains:
        enum:
          - mediatek,mt8192-lvts-ap
          - mediatek,mt8192-lvts-mcu
  then:
    properties:
      nvmem-cells:
        maxItems: 1

     nvmem-cell-names:
       maxItems: 1

  - if:
    properties:
      compatible:
        contains:
          enum:
           - mediatek,mt8195-lvts-ap
           - mediatek,mt8195-lvts-mcu
  then:
    properties:
      nvmem-cells:
        maxItems: 2

     nvmem-cell-names:
       maxItems: 2
[...]

Best regards,
Balsam