Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756124AbXFTXYw (ORCPT ); Wed, 20 Jun 2007 19:24:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753060AbXFTXYp (ORCPT ); Wed, 20 Jun 2007 19:24:45 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:32808 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbXFTXYo (ORCPT ); Wed, 20 Jun 2007 19:24:44 -0400 Subject: Re: [1/2] 2.6.22-rc5: known regressions with patches From: Arjan van de Ven To: Linus Torvalds Cc: Ian McDonald , Andrew Morton , LKML , Miklos Szeredi , Ingo Molnar , "Darrick J. Wong" , Andi Kleen , Bj?rn Steinbrink , William Cohen , "S. P. Prasanna" , Antonino Daplas , Olaf Hering , Ville Syrj?l? , Jean Delvare , Rudolf Marek , Soeren Sonnenburg , Michal Piotrowski In-Reply-To: References: <467543FA.60905@googlemail.com> <5640c7e00706201508g3c1fc40eq82a1db05c9156b5d@mail.gmail.com> Content-Type: text/plain Organization: Intel International BV Date: Wed, 20 Jun 2007 16:21:07 -0700 Message-Id: <1182381667.2701.7.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.10.2 (2.10.2-2.fc7) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1006 Lines: 31 > Kprobes fundamntally disagrees with DEBUG_RODATA, there's no point in > "working around it". Better just admit it. that's wrong. KPROBE fundamentally disagrees with TEXT being read only, which is a 2.6.22 new "feature".. and a buggy one at that. the real fix would be something like this instead: --- linux-2.6.22-rc5/arch/x86_64/mm/init.c.org 2007-06-21 04:20:10.000000000 -0700 +++ linux-2.6.22-rc5/arch/x86_64/mm/init.c 2007-06-21 04:21:01.000000000 -0700 @@ -605,6 +605,11 @@ void mark_rodata_ro(void) if (num_possible_cpus() > 1) start = (unsigned long)_etext; #endif + +#ifdef CONFIG_KPROBES + start = (unsigned long)_etext; +#endif + end = (unsigned long)__end_rodata; start = (start + PAGE_SIZE - 1) & PAGE_MASK; end &= PAGE_MASK; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/