Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Al Viro' <viro@zeniv.linux.org.uk>,
        Jiangshan Yi <13667453960@163.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "willy@infradead.org" <willy@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jiangshan Yi <yijiangshan@kylinos.cn>
Subject: RE: [PATCH] fs/efs/inode.c: use __func__ instead of function name
Thread-Topic: [PATCH] fs/efs/inode.c: use __func__ instead of function name
Thread-Index: AQHYzIdskrFLZR+H2ka5LnnQ208eAK3ppj5g
Date:   Wed, 21 Sep 2022 09:52:01 +0000
Message-ID: <c024f9d09a68417f8326ec318aec87ce@AcuMS.aculab.com>
References: <20220919023314.3622391-1-13667453960@163.com>
 <YykIOg0ApQycqOxu@ZenIV>
In-Reply-To: <YykIOg0ApQycqOxu@ZenIV>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Al Viro
> Sent: 20 September 2022 01:24
> 
> On Mon, Sep 19, 2022 at 10:33:14AM +0800, Jiangshan Yi wrote:
> > From: Jiangshan Yi <yijiangshan@kylinos.cn>
> >
> > It is better to use __func__ instead of function name.
> 
> 	Why is it better?  And why is it *not* sent to (active)
> maintainers of fs/erofs?  I'm not going to apply that behind their
> backs and I would ask akpm to abstain from taking that one.

It is distinctly worse.
Anyone grepping the kernel source for the message text will
fail to find it.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)