Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Sep 2022 12:37:45 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Michael Walle <michael@walle.cc>
Cc:     Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Frank Rowand <frowand.list@gmail.com>,
        linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Ahmad Fatoum <a.fatoum@pengutronix.de>,
        Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [RFC PATCH v2 19/20] nvmem: layouts: rewrite the u-boot-env
 driver as a NVMEM layout
Message-ID: <20220921123745.61299d6a@xps-13>
In-Reply-To: <20220901221857.2600340-20-michael@walle.cc>
References: <20220901221857.2600340-1-michael@walle.cc>
        <20220901221857.2600340-20-michael@walle.cc>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Michael,

michael@walle.cc wrote on Fri,  2 Sep 2022 00:18:56 +0200:

> Instead of hardcoding the underlying access method mtd_read() and
> duplicating all the error handling, rewrite the driver as a nvmem
> layout which just uses nvmem_device_read() and thus works with any
> NVMEM device.
>=20
> But because this is now not a device anymore, the compatible string
> will have to be changed so the device will still be probed:
>   compatible =3D "u-boot,env";
> to
>   compatible =3D "u-boot,env", "nvmem-cells";
>=20
> "nvmem-cells" will tell the mtd layer to register a nvmem_device().
> "u-boot,env" will tell the NVMEM that it should apply the u-boot
> environment layout to the NVMEM device.
>=20
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> changes since v1:
>  - none
>=20
>  drivers/nvmem/layouts/Kconfig      |   8 ++
>  drivers/nvmem/layouts/Makefile     |   1 +
>  drivers/nvmem/layouts/u-boot-env.c | 144 +++++++++++++++++++
>  drivers/nvmem/u-boot-env.c         | 218 -----------------------------

Nit: IIRC there is a MAINTAINERS entry to update as well.

Thanks,
Miqu=C3=A8l