Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5b74c435-6dec-4346-e237-ad36bfcb9789@linux.alibaba.com>
Date:   Wed, 21 Sep 2022 18:42:24 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v1] mm/vmscan: check the return value of migrate_pages()
To:     Li Zhong <floridsleeves@gmail.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Cc:     akpm@linux-foundation.org
References: <20220917021257.3840548-1-floridsleeves@gmail.com>
From:   Baolin Wang <baolin.wang@linux.alibaba.com>
In-Reply-To: <20220917021257.3840548-1-floridsleeves@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 9/17/2022 10:12 AM, Li Zhong wrote:
> Check the return value of migrate_pages() to check error exeuction.
> 
> Signed-off-by: Li Zhong <floridsleeves@gmail.com>
> ---
>   mm/vmscan.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index b2b1431352dc..50aaaa9377e2 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1547,6 +1547,7 @@ static unsigned int demote_page_list(struct list_head *demote_pages,
>   {
>   	int target_nid = next_demotion_node(pgdat->node_id);
>   	unsigned int nr_succeeded;
> +	int ret;
>   
>   	if (list_empty(demote_pages))
>   		return 0;
> @@ -1555,10 +1556,13 @@ static unsigned int demote_page_list(struct list_head *demote_pages,
>   		return 0;
>   
>   	/* Demotion ignores all cpuset and mempolicy settings */
> -	migrate_pages(demote_pages, alloc_demote_page, NULL,
> +	ret = migrate_pages(demote_pages, alloc_demote_page, NULL,
>   			    target_nid, MIGRATE_ASYNC, MR_DEMOTION,
>   			    &nr_succeeded);
>   
> +	if (ret)
> +		putback_movable_pages(&pagelist);

You can not just put them back into the original lru list, instead the 
caller has handled the failed-to-demote pages, which will try to reclaim 
them.

In addition, the code cannot even be built successfully.