Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757327AbXFUAJz (ORCPT ); Wed, 20 Jun 2007 20:09:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753886AbXFUAJp (ORCPT ); Wed, 20 Jun 2007 20:09:45 -0400 Received: from 216-99-217-87.dsl.aracnet.com ([216.99.217.87]:35911 "EHLO sous-sol.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753386AbXFUAJo (ORCPT ); Wed, 20 Jun 2007 20:09:44 -0400 Date: Wed, 20 Jun 2007 17:09:00 -0700 From: Chris Wright To: Jeff Garzik Cc: Jay Vosburgh , Stephen Hemminger , "David S. Miller" , Dan Aloni , Chad Tindel , Kenji Kaneshige , netdev@vger.kernel.org, linux-kernel , Andrew Morton , bonding-devel@lists.sourceforge.net Subject: Re: [PATCH] bonding: Fix use after free in unregister path Message-ID: <20070621000900.GH3457@sequoia.sous-sol.org> References: <20070511092519.1f34ab34@freepuppy> <1179130660.3881.23.camel@kane-linux> <20070514085840.17a343f7@freepuppy> <20070613094521.GA8860@localdomain> <20070613155335.47111c67@localhost> <15712.1181795790@death> <20070619082302.4b9a5c27@localhost.localdomain> <467817CE.80904@garzik.org> <24302.1182276732@death> <4679B476.9060503@garzik.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4679B476.9060503@garzik.org> User-Agent: Mutt/1.5.14 (2007-02-12) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 27 * Jeff Garzik (jeff@garzik.org) wrote: > Jay Vosburgh wrote: > > The following patch (based on a patch from Stephen Hemminger > >) removes use after free conditions in > >the unregister path for the bonding master. Without this patch, an > >operation of the form "echo -bond0 > /sys/class/net/bonding_masters" > >would trigger a NULL pointer dereference in sysfs. I was not able to > >induce the failure with the non-sysfs code path, but for consistency I > >updated that code as well. > > > > I also did some testing of the bonding /proc file being open > >while the bond is being deleted, and didn't see any problems there. > > > >Signed-off-by: Jay Vosburgh > > applied to #upstream-fixes This was originally discovered on 2.6.21.5 IIRC, so plan to send this to -stable as well? thanks, -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/