Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp5241395rwb; Wed, 21 Sep 2022 05:19:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6pQMSCasn+PQHT4XurVP2g+log1IgTNvUPuOL4aqsqOLR0jl2wEAhF+bpJZ6goPARw7QEv X-Received: by 2002:a17:902:e74f:b0:178:3af4:fb13 with SMTP id p15-20020a170902e74f00b001783af4fb13mr4568898plf.19.1663762763428; Wed, 21 Sep 2022 05:19:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663762763; cv=none; d=google.com; s=arc-20160816; b=yZyPDTTfmVWCVXckiyT5fAKqPLDBAYUqRZKkzTTldvDd0jJ08e0RQpWW+X5LqYNyGg oR6ZchxNPaw2gLkLkUBIBPmiy5gv2u62pSIY8lXLYISznbShUrHqPOGJPjM4SsrIP6gC 0ARuFPQsHDVhysyz5JwQ6tv3njnl5oPMOi0XtG5+rlXyf/VzZcYbwwBc87GVnb1mMwsC 8ZOIO8KOEpDe0vNTxeAhuCfOuewwNW+/VX0JdjiAwxvaCCzMXXvf8wdFfrvgv6DHRL4D cWVvbuLrCfGtbQPLH85wd/Toac+s6tKvHs/kLh2oMhr7TNbtxOhVFkyWfP8H1hEnkDsf 3uRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=HMx4D/NcD0zIrrcg+YBaT0L1ldh75uGJmDtBcB56ctQ=; b=i0BKTEUdDQWmqTCzvEoCU4MXWFuZx2oH51Vcv73KYQ7MuEZzBCOlX0QSQ5HxUOnDdD 2ayj4dAjb0XBMda9CacE7osT96VHRXQQsQHd7pSpEAHv8+PM90IlWP5MTE3DmXHfhVrR nRbhvs7d4vXZIOVA1zWdkaarKWiUif0lFphOKgb60H31lIC+FLR3toBGNJ8OrOv+/a7V H1EF1dNh/9NOM1J4IlvuFsdvOMP4kgXQx8bdKKu3ccIChM//WbWo2K+ueTrQIIu3dY3U 9wD36bwIoUv8pBsesRd1pdG6V31FUDFx4EtK/tq0VgMuE7fWGxdOkoJGwYt883vNLFkt KK5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KRoOTgRv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e2-20020a17090301c200b00171311470f7si3135059plh.3.2022.09.21.05.19.10; Wed, 21 Sep 2022 05:19:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KRoOTgRv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229761AbiIUMAU (ORCPT + 99 others); Wed, 21 Sep 2022 08:00:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbiIUMAS (ORCPT ); Wed, 21 Sep 2022 08:00:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 438937695B; Wed, 21 Sep 2022 05:00:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D749962A84; Wed, 21 Sep 2022 12:00:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 315C8C433D7; Wed, 21 Sep 2022 12:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663761616; bh=i69ZmGdHu5PUuqWlHjhxOd/tkF7768DYdJ7U9BGdZ1w=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=KRoOTgRvcOEg+fOnKAUOqSo0ExLK+AQvs96L604Lz5Zn0GOHVyUOhryZRWPND04lI 0UB0y36PImI4qbh9w3YbPmhfvVUUadHTifhEnkBI4CZrt2xzTND/nTHV6nu4iF4fcg BxD6oL5MXaDS9cY/5xri2v/I8L/At+E/2plSLwi1nQg5bUQTDMf7uBPO+JO+3wHJwI bwIxOm+o6APz92dbmj1vio9YMlhsZbMongQf/YYaA9PossYnjfjpg/4A9wBMnrbNVT Zua7wZ7Kjsg9F2MwY+rkdUrJS+CSsDRyHjQDp6fpOy+8jCOh7umnjx3a50wrBBCj2V VpCQMwYToaTIg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 0FADEE4D03C; Wed, 21 Sep 2022 12:00:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: atlantic: fix potential memory leak in aq_ndev_close() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166376161606.20264.11965749848090373345.git-patchwork-notify@kernel.org> Date: Wed, 21 Sep 2022 12:00:16 +0000 References: <20220914014238.7064-1-niejianglei2021@163.com> In-Reply-To: <20220914014238.7064-1-niejianglei2021@163.com> To: Jianglei Nie Cc: irusskikh@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Wed, 14 Sep 2022 09:42:38 +0800 you wrote: > If aq_nic_stop() fails, aq_ndev_close() returns err without calling > aq_nic_deinit() to release the relevant memory and resource, which > will lead to a memory leak. > > We can fix it by deleting the if condition judgment and goto statement to > call aq_nic_deinit() directly after aq_nic_stop() to fix the memory leak. > > [...] Here is the summary with links: - net: atlantic: fix potential memory leak in aq_ndev_close() https://git.kernel.org/netdev/net/c/65e5d27df612 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html