Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     =?iso-8859-1?Q?Pali_Roh=E1r?= <pali@kernel.org>
CC:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: marvell: phy-mvebu-a3700-comphy: Reset COMPHY
 registers before USB 3.0 power on
Thread-Topic: [PATCH] phy: marvell: phy-mvebu-a3700-comphy: Reset COMPHY
 registers before USB 3.0 power on
Thread-Index: AQHYzOo7ZaCBnnYyIkere1jyQj5pAa3pVQMAgAAzHYCAAE30gA==
Date:   Wed, 21 Sep 2022 12:44:58 +0000
Message-ID: <20220921124457.26hjljy7fcv45zfk@shindev>
References: <20220920121154.30115-1-pali@kernel.org>
 <20220921050300.riwyofdncxscrwe3@shindev>
 <20220921080557.jdg5wywpa5qxcyo2@pali>
In-Reply-To: <20220921080557.jdg5wywpa5qxcyo2@pali>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?5jV+/tYtoyiTB964hf5jdfygvV+qYG5Y9AfmlXxtZwqU/Ce0j8J+PlUH20?=
 =?iso-8859-1?Q?1posp6Ys9I0t01sOID4T09P/F8lVsviQ3Yry7kXGh7cU6fMZdJFt2ea1TD?=
 =?iso-8859-1?Q?3Ko7CkCAGTYlV2Uh7g6//Nl44GAFjAn9I/qhLk8MRn8qPGZQEcKN/qR2XW?=
 =?iso-8859-1?Q?HpTt/yZ1/ON/blNxpFYFHIVkHsm3fS1VY2l4H9p+5ZHdT+aLrU6PS6dN/a?=
 =?iso-8859-1?Q?7jYQkS8Xq8y19b1I1Hd4EwR4psBF0rLqQSF1wDktpR3laLAAz+8c67gPLV?=
 =?iso-8859-1?Q?TuD6xf4qAQ1tES7Zm5umE8jR2nC3EfJwZphEc1sl1JWg6iwsktD1ay0qc7?=
 =?iso-8859-1?Q?JsvPSEpJaoddeWlg3PxC21vq2UCRKRUOobjaO1wNn4mjH0Lpp8a3ZbmYtp?=
 =?iso-8859-1?Q?FoGeG2evTiIm4HaBV0fSTI0g8SiOSO7bsg+Sifcd6OKLZkGXm11wFsisDn?=
 =?iso-8859-1?Q?sI+ZLzF5DR8+gQtH4O3I/Qinw+qFviwlRQtQSGc7Fx1RFEpZmk1FvFBvtr?=
 =?iso-8859-1?Q?BjTjmRjjZbo3RwXtujxNhzmyOil11xoT6y8Wx5lV58lUi70juvmJFPJPGP?=
 =?iso-8859-1?Q?UDTPnt8gqN8Wvi9kWndAMU3554wTLIhKyVPqsSyor0xxcwEdv/n4BMfup0?=
 =?iso-8859-1?Q?ixNRgjpfaC9RQ6nCvgB4nYvzo+gi4iHNmr6OKtddZKro5IPF1gHKi5GekG?=
 =?iso-8859-1?Q?vPtEOz559HMkfHsSFp3mvXFMvnz05KYgSQMkoplzmePEgflwljZfGP4DLF?=
 =?iso-8859-1?Q?0yHTI7Cl/2nf/3eHNU2ynG9PYgM+Vawi8HYxAHZPYhG1gsZHMDBJf2WKBg?=
 =?iso-8859-1?Q?XtN7jk7577ihDMQdaVKIZK9w6cn7WULreiXpJw6Lq6jwDY7L/uYgt16aSL?=
 =?iso-8859-1?Q?uvS9DRK+FzhLXXo6F6qSgIgXPW9fJu8JtjOxnrvpE/oJk/ain80dhBRbCZ?=
 =?iso-8859-1?Q?dtc4E0/uE8cgEoM2DzLqBZb2vmcyllVJcPOkAle1VwzQJSXdKeOHD3CSq5?=
 =?iso-8859-1?Q?PuofrmRl0bdITLvq8tQC4hD48WocAJ4E/Fr82tx09mgBi4IPDavj9MOrhT?=
 =?iso-8859-1?Q?S4fMRCwJUJnFtO4kGLQZPgrwtpVm/mmfyQAtPFfkwuKAAuT2btQFaa1hqY?=
 =?iso-8859-1?Q?lSxSyNDClyl8D7dt6AOv/Nw8w8j1VBQidUPCXZRjAWVnKAgVmGwsX//my7?=
 =?iso-8859-1?Q?+eV961HwNUZRkTM279x0gYQF/lNV63CU944Sed4o8yACGNEJbx09wKCS18?=
 =?iso-8859-1?Q?Xb/VIKhxr7c/uox2uICEcechxjGjq5xVrmCYGd2r6k/M0sB2tqjMYvWhKO?=
 =?iso-8859-1?Q?jLDMushTeX7BCR7UaahYuii6W7WGT/VnOtlx/UzY/4kGr4l4U/0nHWDplh?=
 =?iso-8859-1?Q?K2toiYsZomT1jHU9t2eNszYdpO5hGhnMSJPBW8Nln3IO1dQxKf4fQUfiWT?=
 =?iso-8859-1?Q?eo39cU34ruSEiOrBUq0baAtDG56FvhWi2EFdqmLCgWehfLYHuzmjnglqFT?=
 =?iso-8859-1?Q?u+fReWls/ffxnzkxQ8Y6BKn73Y/U5IURkrlMURgDbl44l6/XY6XuFzQNSF?=
 =?iso-8859-1?Q?hpF0ICtJYhCQctjfRQC0LIZV89HiNFCCfc3VSZwewuuiAcqE7t3i9QTdS0?=
 =?iso-8859-1?Q?rXuePMZS4hruZhil1afFvWcwoqQgNDCtBU9jFwyHwAJ2be3FsUqb9I+kRm?=
 =?iso-8859-1?Q?Z+amWYmqLbwdPEAsIV4=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <AA5FF8C9E036BC48BF07CF2D730F98BC@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89cadd3c-41c1-4fd6-a271-08da9bcf1792
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 12:44:58.1742
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /U45scz2VqYCdYYI2+8ni8Q7T5IJw23WuEiHeIzdtb34Hv0JzhmFgRs8NLXq2K1QGYK84PgojnKZVdkVGWQEYlyBHxmKYN/qGDrC2Tn9KmI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB0688
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sep 21, 2022 / 08:05, Pali Roh=E1r wrote:
> On Wednesday 21 September 2022 05:03:01 Shinichiro Kawasaki wrote:
> > On Sep 20, 2022 / 14:11, Pali Roh=E1r wrote:
> > > Turris MOX board with older ARM Trusted Firmware version v1.5 is not =
able
> > > to detect any USB 3.0 device connected to USB-A port on Mox-A module =
after
> > > commit 0a6fc70d76bd ("phy: marvell: phy-mvebu-a3700-comphy: Remove br=
oken
> > > reset support"). On the other hand USB 2.0 devices connected to the s=
ame
> > > USB-A port are working fine.
> > >=20
> > > It looks as if the older firmware configures COMPHY registers for USB=
 3.0
> > > somehow incompatibly for kernel driver. Experiments show that resetti=
ng
> > > COMPHY registers via setting SFT_RST auto-clearing bit in COMPHY_SFT_=
RESET
> > > register fixes this issue.
> > >=20
> > > Reset the COMPHY in mvebu_a3700_comphy_usb3_power_on() function as a =
first
> > > step after selecting COMPHY lane and USB 3.0 function. With this chan=
ge
> > > Turris MOX board can successfully detect USB 3.0 devices again.
> > >=20
> > > Before the above mentioned commit this reset was implemented in PHY r=
eset
> > > method, so this is the reason why there was no issue with older firmw=
are
> > > version then.
> > >=20
> > > Fixes: 0a6fc70d76bd ("phy: marvell: phy-mvebu-a3700-comphy: Remove br=
oken reset support")
> > > Reported-by: Marek Beh=FAn <kabel@kernel.org>
> > > Signed-off-by: Pali Roh=E1r <pali@kernel.org>
> > > ---
> > > Shinichiro, could you please check that all USB functionality still
> > > works correctly on your board?
> > > ---
> >=20
> > Sure. TL;DR, this patch works ok for my espressobin v7 board.
> >=20
> > Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> >=20
> > I prepared base kernel v5.19.10 applying the commit 0a6fc70d76bd. Regar=
dless
> > whether this fix patch for Turrix MOX board is applied or not, two USB =
ports on
> > my esprssobin v7 board worked as expected. I confirmed it by using USB =
thumb
> > drive. The drive was detected and its partition was mounted successfull=
y using
> > either of the two USB ports.
>=20
> Thank you for testing! Anyway, please check that USB 3.0 device is
> working fine. Because as I wrote in commit message, on Turris Mox was
> USB 2.0 device working fine, but USB 3.0 not. And maybe check in system
> (lsusb) that USB 3.0 device was really detected as USB 3.0 because USB
> 3.0 devices have supported also fallback USB 2.0/1.x legacy mode.

Ah, I see. For that check, I connected my USB 3.1 drive to the USB 3.0 port=
 of
my espressobin, then checked 'lsusb -vt' and sysfs:

$ lsusb -vt
/:  Bus 03.Port 1: Dev 1, Class=3Droot_hub, Driver=3Dxhci-hcd/1p, 5000M
    ID 1d6b:0003 Linux Foundation 3.0 root hub
    |__ Port 1: Dev 2, If 0, Class=3DMass Storage, Driver=3Dusb-storage, 50=
00M
        ID 0781:5583 SanDisk Corp. Ultra Fit
/:  Bus 02.Port 1: Dev 1, Class=3Droot_hub, Driver=3Dxhci-hcd/1p, 480M
    ID 1d6b:0002 Linux Foundation 2.0 root hub
/:  Bus 01.Port 1: Dev 1, Class=3Droot_hub, Driver=3Dorion-ehci/1p, 480M
    ID 1d6b:0002 Linux Foundation 2.0 root hub

$ cat /sys/bus/usb/devices/3-1/version=20
 3.00

USB3 port is listed under the Bus 03, "3.0" root hub. According to sysfs, i=
ts
USB version is 3.00. I observed same outputs with and without the patch for
Turris MOX board.

Are these good enough? If other check is needed, please let me know.

--=20
Shin'ichiro Kawasaki=