Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220920064648.215375-1-ye.xingchen@zte.com.cn>
In-Reply-To: <20220920064648.215375-1-ye.xingchen@zte.com.cn>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Wed, 21 Sep 2022 14:49:30 +0200
Message-ID: <CAPDyKFpNwQfsbOmmp3i1XyggSVbJ8NO89MneyUh30aahjHdhRA@mail.gmail.com>
Subject: Re: [PATCH linux-next] mmc: rtsx_usb_sdmmc: Remove the unneeded
 result variable
To:     cgel.zte@gmail.com
Cc:     linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        ye xingchen <ye.xingchen@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 20 Sept 2022 at 08:46, <cgel.zte@gmail.com> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value rtsx_usb_send_cmd() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/rtsx_usb_sdmmc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c
> index 5fe4528e296e..5798aee06653 100644
> --- a/drivers/mmc/host/rtsx_usb_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
> @@ -1042,7 +1042,6 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host,
>                 unsigned char timing, bool *ddr_mode)
>  {
>         struct rtsx_ucr *ucr = host->ucr;
> -       int err;
>
>         *ddr_mode = false;
>
> @@ -1097,9 +1096,7 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host,
>                 break;
>         }
>
> -       err = rtsx_usb_send_cmd(ucr, MODE_C, 100);
> -
> -       return err;
> +       return rtsx_usb_send_cmd(ucr, MODE_C, 100);
>  }
>
>  static void sdmmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> --
> 2.25.1