Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220908171153.670762-1-nfraprado@collabora.com> <20220908171153.670762-2-nfraprado@collabora.com>
In-Reply-To: <20220908171153.670762-2-nfraprado@collabora.com>
From:   Chen-Yu Tsai <wenst@chromium.org>
Date:   Wed, 21 Sep 2022 22:20:43 +0800
Message-ID: <CAGXv+5FErSBT-t6vz_2naApuPoC4PympWft-9Gd_MMPUTN+CsQ@mail.gmail.com>
Subject: Re: [PATCH 1/3] arm64: dts: mediatek: asurada: Add display regulators
To:     =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= 
        <nfraprado@collabora.com>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, kernel@collabora.com,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Fri, Sep 9, 2022 at 1:12 AM N=C3=ADcolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
>
> Add the regulators present on the Asurada platform that are used to
> power the internal and external displays.
>
> Signed-off-by: N=C3=ADcolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
>
>  .../boot/dts/mediatek/mt8192-asurada.dtsi     | 114 ++++++++++++++++++
>  1 file changed, 114 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm6=
4/boot/dts/mediatek/mt8192-asurada.dtsi
> index 4b314435f8fd..1d99e470ea1a 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
> @@ -23,6 +23,42 @@ memory@40000000 {
>                 reg =3D <0 0x40000000 0 0x80000000>;
>         };
>
> +       pp1000_dpbrdg: regulator-1v0-dpbrdg {
> +               compatible =3D "regulator-fixed";
> +               regulator-name =3D "pp1000_dpbrdg";
> +               pinctrl-names =3D "default";
> +               pinctrl-0 =3D <&pp1000_dpbrdg_en_pins>;
> +               regulator-min-microvolt =3D <1000000>;
> +               regulator-max-microvolt =3D <1000000>;

This is fed by a rail called PP1350_VS2, which is from the MT6359 PMIC.
And this regulator is a proper LDO.

> +               enable-active-high;
> +               regulator-boot-on;
> +               gpio =3D <&pio 19 GPIO_ACTIVE_HIGH>;
> +       };
> +
> +       pp1000_mipibrdg: regulator-1v0-mipibrdg {
> +               compatible =3D "regulator-fixed";
> +               regulator-name =3D "pp1000_mipibrdg";
> +               pinctrl-names =3D "default";
> +               pinctrl-0 =3D <&pp1000_mipibrdg_en_pins>;
> +               regulator-min-microvolt =3D <1000000>;
> +               regulator-max-microvolt =3D <1000000>;

This is fed by a rail called PP1350_VS2, which is from the MT6359 PMIC.
And this regulator is a proper LDO.

> +               enable-active-high;
> +               regulator-boot-on;
> +               gpio =3D <&pio 129 GPIO_ACTIVE_HIGH>;
> +       };
> +
> +       pp1800_dpbrdg: regulator-1v8-dpbrdg {
> +               compatible =3D "regulator-fixed";
> +               regulator-name =3D "pp1800_dpbrdg";
> +               pinctrl-names =3D "default";
> +               pinctrl-0 =3D <&pp1800_dpbrdg_en_pins>;
> +               regulator-min-microvolt =3D <1800000>;
> +               regulator-max-microvolt =3D <1800000>;

This regulator is only a power switch. Please drop the min/max properties.
This is fed by a rail called PP1800_VIO18_U, which is from an LDO on the
MT6359 PMIC.

> +               enable-active-high;
> +               regulator-boot-on;
> +               gpio =3D <&pio 126 GPIO_ACTIVE_HIGH>;
> +       };
> +
>         /* system wide LDO 1.8V power rail */
>         pp1800_ldo_g: regulator-1v8-g {
>                 compatible =3D "regulator-fixed";
> @@ -34,6 +70,30 @@ pp1800_ldo_g: regulator-1v8-g {
>                 vin-supply =3D <&pp3300_g>;
>         };
>
> +       pp1800_mipibrdg: regulator-1v8-mipibrdg {
> +               compatible =3D "regulator-fixed";
> +               regulator-name =3D "pp1800_mipibrdg";
> +               pinctrl-names =3D "default";
> +               pinctrl-0 =3D <&pp1800_mipibrdg_en_pins>;
> +               regulator-min-microvolt =3D <1800000>;
> +               regulator-max-microvolt =3D <1800000>;

This regulator is only a power switch. Please drop the min/max properties.
This is fed by a rail called PP1800_VIO18_U, which is from an LDO on the
MT6359 PMIC.

> +               enable-active-high;
> +               regulator-boot-on;
> +               gpio =3D <&pio 128 GPIO_ACTIVE_HIGH>;
> +       };
> +
> +       pp3300_dpbrdg: regulator-3v3-dpbrdg {
> +               compatible =3D "regulator-fixed";
> +               regulator-name =3D "pp3300_dpbrdg";
> +               pinctrl-names =3D "default";
> +               pinctrl-0 =3D <&pp3300_dpbrdg_en_pins>;
> +               regulator-min-microvolt =3D <3300000>;
> +               regulator-max-microvolt =3D <3300000>;

This regulator is only a power switch. Please drop the min/max properties.
This is fed by a rail called PP3300_G, which is already described below.

> +               enable-active-high;
> +               regulator-boot-on;
> +               gpio =3D <&pio 26 GPIO_ACTIVE_HIGH>;
> +       };
> +
>         /* system wide switching 3.3V power rail */
>         pp3300_g: regulator-3v3-g {
>                 compatible =3D "regulator-fixed";
> @@ -56,6 +116,18 @@ pp3300_ldo_z: regulator-3v3-z {
>                 vin-supply =3D <&ppvar_sys>;
>         };
>
> +       pp3300_mipibrdg: regulator-3v3-mipibrdg {
> +               compatible =3D "regulator-fixed";
> +               regulator-name =3D "pp3300_mipibrdg";
> +               pinctrl-names =3D "default";
> +               pinctrl-0 =3D <&pp3300_mipibrdg_en_pins>;
> +               regulator-min-microvolt =3D <3300000>;
> +               regulator-max-microvolt =3D <3300000>;

This regulator is only a power switch. Please drop the min/max properties.
This is fed by a rail called PP3300_G, which is already described above.

ChenYu

> +               enable-active-high;
> +               regulator-boot-on;
> +               gpio =3D <&pio 127 GPIO_ACTIVE_HIGH>;
> +       };
> +
>         /* separately switched 3.3V power rail */
>         pp3300_u: regulator-3v3-u {
>                 compatible =3D "regulator-fixed";
> @@ -719,6 +791,48 @@ pins-wifi-kill {
>                 };
>         };
>
> +       pp1000_dpbrdg_en_pins: pp1000-dpbrdg-en-pins {
> +               pins-en {
> +                       pinmux =3D <PINMUX_GPIO19__FUNC_GPIO19>;
> +                       output-low;
> +               };
> +       };
> +
> +       pp1000_mipibrdg_en_pins: pp1000-mipibrdg-en-pins {
> +               pins-en {
> +                       pinmux =3D <PINMUX_GPIO129__FUNC_GPIO129>;
> +                       output-low;
> +               };
> +       };
> +
> +       pp1800_dpbrdg_en_pins: pp1800-dpbrdg-en-pins {
> +               pins-en {
> +                       pinmux =3D <PINMUX_GPIO126__FUNC_GPIO126>;
> +                       output-low;
> +               };
> +       };
> +
> +       pp1800_mipibrdg_en_pins: pp1800-mipibrd-en-pins {
> +               pins-en {
> +                       pinmux =3D <PINMUX_GPIO128__FUNC_GPIO128>;
> +                       output-low;
> +               };
> +       };
> +
> +       pp3300_dpbrdg_en_pins: pp3300-dpbrdg-en-pins {
> +               pins-en {
> +                       pinmux =3D <PINMUX_GPIO26__FUNC_GPIO26>;
> +                       output-low;
> +               };
> +       };
> +
> +       pp3300_mipibrdg_en_pins: pp3300-mipibrdg-en-pins {
> +               pins-en {
> +                       pinmux =3D <PINMUX_GPIO127__FUNC_GPIO127>;
> +                       output-low;
> +               };
> +       };
> +
>         pp3300_wlan_pins: pp3300-wlan-pins {
>                 pins-pcie-en-pp3300-wlan {
>                         pinmux =3D <PINMUX_GPIO143__FUNC_GPIO143>;
> --
> 2.37.3
>