Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <57f5b28d-3a21-3d1e-422d-d79eebefb8e5@roeck-us.net>
Date:   Wed, 21 Sep 2022 07:02:27 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] hwmon: (mr75203) fix undefined reference to `__divdi3'
Content-Language: en-US
To:     Eliav Farber <farbere@amazon.com>, jdelvare@suse.com,
        linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
        andriy.shevchenko@intel.com, sudipm.mukherjee@gmail.com
Cc:     hhhawa@amazon.com, jonnyc@amazon.com,
        kernel test robot <lkp@intel.com>
References: <20220921121723.6726-1-farbere@amazon.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20220921121723.6726-1-farbere@amazon.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/21/22 05:17, Eliav Farber wrote:
> Fix build error on 32-bit machines.
> 
> Fixes: 381a86c545f1 ("hwmon: (mr75203) modify the temperature equation according to series 5 datasheet")
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> Reported-by: kernel test robot <lkp@intel.com>

Applied.

> ---
> I will also rework it into the original series (since it's not just a
> trivial squash into one previous commit) and you can decide what to use
> according to your preference.
> 

I rather keep this patch separate.

Thanks,
Guenter

>   drivers/hwmon/mr75203.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
> index 0fea443dc3e1..9c400cf790b5 100644
> --- a/drivers/hwmon/mr75203.c
> +++ b/drivers/hwmon/mr75203.c
> @@ -266,9 +266,9 @@ static long pvt_calc_temp(struct pvt_device *pvt, u32 nbs)
>   	struct temp_coeff *ts_coeff = &pvt->ts_coeff;
>   
>   	s64 tmp = ts_coeff->g +
> -		ts_coeff->h * (s64)nbs / ts_coeff->cal5 -
> +		div_s64(ts_coeff->h * (s64)nbs, ts_coeff->cal5) -
>   		ts_coeff->h / 2 +
> -		ts_coeff->j * (s64)pvt->ip_freq / HZ_PER_MHZ;
> +		div_s64(ts_coeff->j * (s64)pvt->ip_freq, HZ_PER_MHZ);
>   
>   	return clamp_val(tmp, PVT_TEMP_MIN_mC, PVT_TEMP_MAX_mC);
>   }