Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Sep 2022 16:25:25 +0200
From:   Niklas =?iso-8859-1?Q?S=F6derlund?= 
        <niklas.soderlund@corigine.com>
To:     Joe Perches <joe@perches.com>
Cc:     Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Andy Whitcroft <apw@canonical.com>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Philippe Schenker <philippe.schenker@toradex.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        oss-drivers@corigine.com, Simon Horman <simon.horman@corigine.com>,
        Louis Peens <louis.peens@corigine.com>
Subject: Re: [PATCH v7] checkpatch: warn for non-standard fixes tag style
Message-ID: <Yyse1XvsdiIJ3dun@oden.dyn.berto.se>
References: <20220914100255.1048460-1-niklas.soderlund@corigine.com>
 <aa858ac592679fdf512debe17e0612c575450860.camel@perches.com>
 <YyLtEza0VhSbflvH@oden.dyn.berto.se>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YyLtEza0VhSbflvH@oden.dyn.berto.se>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?CkBv3IOzz8OH7N74GfX1/7TWlchwexxTmM4P9BOmV1ahr9hm2dVFV9e8Nk?=
 =?iso-8859-1?Q?uo+kVS41TCqN0t7CkTTbjiv195/Rn3t864dg26IMh2Z90FPy/C/f6U+LVQ?=
 =?iso-8859-1?Q?DeQhn9DGar3iK6qewCflkEWSOmIpMUj/kWmdDoDix8Dn8E2n29wgX4yApA?=
 =?iso-8859-1?Q?QjvYuJ36fAIrJRv1fMOYc/8iJSJEgnm8/LIqOBLOxDRvCJDz1o9uFpXxok?=
 =?iso-8859-1?Q?no457TLfRtiAuP3ZoJ/GkMRomoQ/P2NxbVeuxukMfv+VEbzcIv+7JLHjae?=
 =?iso-8859-1?Q?SWMLrVhsgs0XqzgRHAxqBgYSbyn9IakD9jf8auEpM00PODQqN8kv1qDv1K?=
 =?iso-8859-1?Q?xiklOUXVDKau3i5HnurtT1GLHYK3vvty9nPzCIqaUa2a/cbEYkwbomhHZE?=
 =?iso-8859-1?Q?MfPjkV6CwJlr640QHJ8Y0CSWS5MFgvlJ8ditfHVuAhHrLWveLlB0diCXtk?=
 =?iso-8859-1?Q?CZnr2O2Dyz092bSqgx1wUbqdUqeircJk1bsc8fRlJNZHa2LBnbIkB+4XLH?=
 =?iso-8859-1?Q?+CPuQt7WFuE1w4loT+J+lEvK1OUEIQE06pbx6J5xDzgHvvOLCWg0wJ8cjy?=
 =?iso-8859-1?Q?oRO6BueRs7IXMQNzZvqgJBC07KJglWAXTmgtyC73ivgxft+Pybm4ysrVFu?=
 =?iso-8859-1?Q?whXJGdp6Hz6o1AHPoMF523ORX74EAjaZg0K8mz9VRFlivO7E/ippKQ0dpq?=
 =?iso-8859-1?Q?qT1d1ija2+dF9sWFj+uTdlYvgvs7JlLo0ye5NQBixr3POTRLYyKt/8P51G?=
 =?iso-8859-1?Q?TJioWgmLpp/B2Vcx/ARYfl2Q38Nin2IDOqlQUW9qwqqDr7tshTAhs3qKYI?=
 =?iso-8859-1?Q?dDoeCAOuAI6O8pggY9EYnzNRB33ir47OTNYEXg6cmuePz39uLFCLZKHlua?=
 =?iso-8859-1?Q?wa+DkugRW7HStbB0XYZzl2bOWl3HudO9qUB0YuslIqaeIXZSJhx5He9vKA?=
 =?iso-8859-1?Q?RgF6LRPTaPySdS9z/fqury5NVYSWkeMKv1gUapJSwXETNifq6ZPtPlVtuS?=
 =?iso-8859-1?Q?Mo13iro7Vss/9E/NwRfIYAD/AgACTFOBUVAGPfJCjpi795PkoR+3QJX6ct?=
 =?iso-8859-1?Q?3gSQpoBrWdXlvI19xuAmWr3mUbqhgM8JQITVAILieHpJvq1QxFLyz4zusP?=
 =?iso-8859-1?Q?HsOInBsGoFkanlezVMvHBkeAwA4xByMw6iRP52W0sL70dHyPCMhDvs7Wy4?=
 =?iso-8859-1?Q?QwWeJnw0S/oXioP1lkD7gHCsqPM87aHAn59UP8WlELrQy5hGVV7Xtii5GX?=
 =?iso-8859-1?Q?XjK74tY77mSXNxozaXemj05Jz04p2St2g4TRZinKWSiYhG2vRhmqCudOPa?=
 =?iso-8859-1?Q?cN5K33kIZQ+hpIdzPrB2YeV/mnV64x65c7TH8KTzzmHJbv6Rl1TKQLB2M2?=
 =?iso-8859-1?Q?yVPe5VL8BZq3C7KPufL9ggz4EC9MjF7l6wai8E9wOS+2g6Wf9h3IcgAEFm?=
 =?iso-8859-1?Q?9Cgtx5OJS5HsvTypgS7Gx3TVc3nXR/xFxN2YlgT05PHRqffsdXJgz+PCGK?=
 =?iso-8859-1?Q?JDRHbdqRddMlZGMo1lGJXZFlBmh5QhsipMsGKm169zRFMb0qTkimdTQug7?=
 =?iso-8859-1?Q?6Bn+Z1V17HMtRWWYrJA1xosPpGAT+bTSRIiGhgLkzKqpaUvFjgCmx1C5gS?=
 =?iso-8859-1?Q?ntGtoxZcquPxr/0fNmcdU8L0822eV+BEwMUbUbmxsgQgMn1WMi9Q0IYQ?=
 =?iso-8859-1?Q?=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f1d10f7-fdad-45b7-c5fe-08da9bdd237a
X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB4431.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 14:25:31.3078
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PD3+yNg+Xao+3Elacey1cnFyA0Mp2xaaGnSP0T7+Bnu0nmWNbwzOAiT3aO1Ke3to3OQgpx7pec9XqzavyI9Vke3DybCFDLkd2cmoew+MrgI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5407
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Joe,

Just wanted to check on my misunderstanding below before posting a v8.

On 2022-09-15 11:15:06 +0200, Niklas S?derlund wrote:
> Hi Joe,
> 
> On 2022-09-14 09:09:25 -0700, Joe Perches wrote:
> > On Wed, 2022-09-14 at 12:02 +0200, Niklas S?derlund wrote:
> > > Add a warning for fixes tags that does not follow community conventions.
> > []
> > > * Changes since v6
> > > - Update first check to make sure that there is a likely SHA1 of some
> > >   minimum length after the fixes line.
> > 
> > https://lore.kernel.org/lkml/2febb7893346b6234983453de7c037536e479bfc.camel@perches.com/
> > 
> > The goal here should be to identify a line that looks like a commit
> > reference.
> > 
> > So find lines that starts with 'fixes' and have a SHA1 commit id as
> > broadly as reasonable.
> > 
> > Did you run the grep pattern and look at the results?
> > 
> > One grep pattern to verify the non canonical fixes format that
> > are mistakenly used is:
> > 
> > $ git log --since=5-years-ago --no-merges --grep='^\s*fixes' -i --format=email -P | \
> >   grep -P -i '^\s*fixes' | \
> >   grep -P -v '^Fixes: [0-9a-f]{12,12}\s*\(".*")'
> > 
> > []
> > 
> > There are many different styles.
> > Parenthesea are sometimes not used.
> 
> I understand this, and I did have a look at it.
> 
> > 
> > > +			if ($line =~ /(\s*fixes:?)\s+([0-9a-f]{5,})\s+($balanced_parens)/i) {
> > 
> > How about some pattern like
> > 
> > 	/fixes\s*:?\s*(?:commit:?\s*)?[0-9a-f]{5,}/i
> > 
> > or maybe even more broadly:
> > 
> > 	/fixes\b.*\b[0-9a-f]{5,}\b/i
> 
> Maybe I misunderstand your comment, but this is what I do in this patch?
> 
>     if (!$in_header_lines &&
>         $line =~ /^\s*fixes:?\s*(?:commit\s*)?[0-9a-f]{5,}\b/i) {
> 
>         ...
> 
>         if ($line =~ /(\s*fixes:?)\s+([0-9a-f]{5,})\s+($balanced_parens)/i) {
>             ...
>         }
>     }
> 
> This will catch and warn about such tags but not attempt to break out 
> it's components in order to suggest a potentially more correct fix. Is 
> it this second filter you would like me to change?
> 
> -- 
> Kind Regards,
> Niklas S?derlund

-- 
Kind Regards,
Niklas S?derlund