Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220916111912.42733-1-vijayenthiran.subramaniam@arm.com> <20220916130035.pbavnjlkh4envc4u@bogus>
In-Reply-To: <20220916130035.pbavnjlkh4envc4u@bogus>
From:   Vijayenthiran Subramanian <vijayenthiran.subramaniam@arm.com>
Date:   Wed, 21 Sep 2022 14:42:38 +0000
Message-ID: <CAC0BY-fpRTie=CA+kOK2aRYdchZDiMOmUvyykA+aNEgmyAB9mA@mail.gmail.com>
Subject: Re: [PATCH] coresight: acpi: add support for amba dma-330 controller
To:     Sudeep Holla <sudeep.holla@arm.com>
Cc:     Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>,
        rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        coresight@lists.linaro.org, suzuki.poulose@arm.com,
        thomas.abraham@arm.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Sudeep,

On Fri, Sep 16, 2022 at 1:06 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> On Fri, Sep 16, 2022 at 04:49:12PM +0530, Vijayenthiran Subramaniam wrote:
> > Add ACPI ID for ARM DMA-330 controller to AMBA id list to allow the
> > probing of the device.
> >
>
> $subject pattern is simply wrong and I see this is just copied from the
> previous commit which makes no sense here. You can see other commits
> and their patterns too.
>
> Use prefix something like:
> ACPI / amba:
> or
> ACPI: amba:
>
> Also "Add .." in the $subject sounds like you are adding the support for
> the controller here which is not the case.
>
> Enable support for Arm Primecell PL330 dma controller
> Or
> Add Arm Primecell PL330 dma controller to the supported list

Ack.

I have posted v2 with the subject:
[PATCH v2] ACPI: amba: Add Arm DMA-330 controller to the supported list.

>
> --
> Regards,
> Sudeep