Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp5467292rwb; Wed, 21 Sep 2022 08:11:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM64Y+EeuTy4c2/6Avv6fRcBz2MVHbuEEVyf0gTFq6P1uAHAUZzGhCQXasvytn20oOyAvrLN X-Received: by 2002:a05:6402:e9d:b0:443:7833:3d7b with SMTP id h29-20020a0564020e9d00b0044378333d7bmr14545389eda.151.1663773083313; Wed, 21 Sep 2022 08:11:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663773083; cv=none; d=google.com; s=arc-20160816; b=wyWx08+SHHla3e/JixtEunykO0+9r5CKixyk5gY+/8+mnZuVokeT1s6P63UngEfsB5 +NDEoY6wX6NCGqG1eGaQIxXc/FMEJcrNnL/Af5pQ12/yHCQRuq7hKSE2o/otg3aI89Fv DQdUsoJooI2a/c5ZgjVpMAOkY4DIR1Xp+FzGIw+J9Axx+DH2FQl7RW7CZ5VqlxcRp85J Wlxwru0Qopz7vfz7wemoD2BupXIk1055q3r9BKT1cilN9BAiMMP8XNOy5AT26t1CQs8o K2RLKj2qLqSwkNSCLUhcRQEI7qkUzWN05tkQK/wacBC6dJz0spKMHPEfHx+GaUYEuwyE X3qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=l3qZPwtiCgZFrRSSVJUxq4Hku+WI2o0fm5ceE68Rjfg=; b=aepvGi5Chgab/t3L0VFGIvQ8P2JaKxZC1fEcuQ+CAJ+VOhlarWYodtPwvWdyfQWBrH 75l0emsdvMFFzFqDypZZ8IYK9xikMxef1sIdajY3Dibx69mmLr2kTleq3pfwl7YmBTsT s5KxX6YoDBQbTLUCw3d++ttV4IW3GZSlTDSU/eFzUxWqeGGYNR3i0bGpcr5MjaifTk2o lfsLk7m/HOVhzDjBop8ZJ5DlQKCn+XkBJfJpZrn1AsTM2iv09vffpm/OgEWm/A/7SwTH /D/VpHk9aMxOvhs+3TFnYW9RQr++elza27UP8rR1KzQCAWOLN8tU/8Y+TsM6XA6KB927 ySmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Zi8uPZEk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bt11-20020a170906b14b00b00770534b5a71si2136396ejb.858.2022.09.21.08.10.55; Wed, 21 Sep 2022 08:11:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Zi8uPZEk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230161AbiIUOr1 (ORCPT + 99 others); Wed, 21 Sep 2022 10:47:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229974AbiIUOrR (ORCPT ); Wed, 21 Sep 2022 10:47:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 388A89835C; Wed, 21 Sep 2022 07:47:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6843261CF5; Wed, 21 Sep 2022 14:47:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6568FC433D6; Wed, 21 Sep 2022 14:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663771627; bh=vA63dnuahnhCE3YTH1Y9D3wDgCIKrDiu7xCHCLKXjys=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zi8uPZEkf4MQtaahUsqjgDLjlangK/V1F6GT+oXQPvtR4hPhDjT/QcrtnuAaH+f1b 5JVmGb7Ar12iBe2RrXkWJKOo3EODaZ/qum4ricRPDvau5HWeYcvlFg6UKsJQzFj5Oy uDlQ9h2+K7YF0ce2KvJbbe5uCq+GBsZhHJCcTvTE= Date: Wed, 21 Sep 2022 16:47:04 +0200 From: Greg KH To: Jens Axboe Cc: Thorsten Leemhuis , Christoph Hellwig , Dusty Mabe , Ming Lei , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, "regressions@lists.linux.dev" Subject: Re: regression caused by block: freeze the queue earlier in del_gendisk Message-ID: References: <20220912071618.GA4971@lst.de> <95cbd47d-46ed-850e-7d4f-851b35d03069@dustymabe.com> <20220920141217.GA12560@lst.de> <9594af4b-eb16-0a51-9a4a-e21bbce3317d@kernel.dk> <6a3660b2-fa7d-14a2-6977-f50926ad369c@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2022 at 08:34:26AM -0600, Jens Axboe wrote: > On 9/21/22 3:25 AM, Thorsten Leemhuis wrote: > > On 20.09.22 16:14, Jens Axboe wrote: > >> On 9/20/22 8:12 AM, Christoph Hellwig wrote: > >>> On Tue, Sep 20, 2022 at 08:05:06AM -0600, Jens Axboe wrote: > >>>> Christoph and I discussed this one last week, and he has a plan to try > >>>> a flag approach. Christoph, did you get a chance to bang that out? Would > >>>> be nice to get this one wrapped up. > >>> > >>> I gave up on that as it will be far too much change so late in > >>> the cycle and sent you the revert yesterday. > >> > >> Gotcha, haven't made it all the way through the emails of the morning yet. > >> I'll queue it up. > > > > Thx to both of you for taking care of this. > > > > Nitpicking: that patch is missing a "CC: stable@..." tag to ensure > > automatic and quick backporting to 5.19.y. Or is the block layer among > > the subsystems that prefer to handle such things manually? > > > > Ohh, and a fixes tag might have been good as well; a "Link:" tag > > pointing to the report, too. If either would have been there, regzbot > > would have noticed Christoph's patch posting and I wouldn't have > > bothered you yesterday. :-) But whatever, not that important. > > We'll just have to ensure we ping stable on it when it goes in. If you have a git id that is not going to change, I can watch out for it to land in Linus's tree... thanks, greg k-h