Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7a5e5b07-2870-d47e-c364-b09d004cf873@gpxsee.org>
Date:   Wed, 21 Sep 2022 17:35:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH v2 2/3] Added Xilinx XDMA IP core driver
Content-Language: en-US
To:     Lizhi Hou <lizhi.hou@amd.com>
Cc:     dmaengine@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        martin.tuma@digiteqautomotive.com, mchehab@kernel.org,
        michal.simek@xilinx.com, vkoul@kernel.org
References: <19bd8ce4-2dde-e985-00f4-09b48decd3dc@amd.com>
 <e084352e-a784-accd-f267-9e0c30c7a92b@gpxsee.org>
 <921a1da6-e378-2632-7b68-ac59e3c24f68@amd.com>
From:   =?UTF-8?Q?Martin_T=c5=afma?= <tumic@gpxsee.org>
In-Reply-To: <921a1da6-e378-2632-7b68-ac59e3c24f68@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 21. 09. 22 17:15, Lizhi Hou wrote:
> 
> On 9/21/22 02:25, Martin Tůma wrote:
>> > Currently, the V3 patch series does not support register user logic
>> > interrupt yet.
>>
>> This is a showstopper for almost every XDMA based PCIe card. As the 
>> driver "consumes" the whole register space (including the user IRQs 
>> enable/disable registers), there is AFAIK no way how to enable the 
>> user IRQs when this driver is loaded.
>>
>> > Could you convert your driver to use this?
>>
>> Not without the user IRQs.
> 
> I provided the patch link for user logic IRQ support in previous reply. 
> You may pull it and patch it on top of the V3 patch series.
> 
> 
> Lizhi
> 
>>
>> M.

I'm sorry, I have missed that. With that modification it should be 
(theoretically - haven't tested it yet) possible to use our v4l2 driver 
with this XDMA driver instead of the one I have provided in my patches.

I will now try to rewrite our driver and test it with your XDMA driver 
to be sure it works. It will however definitely need a "V4" of your XDMA 
driver with that patch on github before it can be included into the 
kernel and be usable for all XDMA-based PCIe cards.

M.