Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Sep 2022 21:44:39 +0200
From:   Wolfram Sang <wsa+renesas@sang-engineering.com>
To:     Asmaa Mnebhi <asmaa@nvidia.com>
Cc:     linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        Khalil Blaiech <kblaiech@nvidia.com>
Subject: Re: [PATCH v5 1/8] i2c: i2c-mlxbf.c: Fix frequency calculation
Message-ID: <Yytpp4c9Brcnx5s3@shikoro>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Asmaa Mnebhi <asmaa@nvidia.com>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, Khalil Blaiech <kblaiech@nvidia.com>
References: <20220920174736.9766-1-asmaa@nvidia.com>
 <20220920174736.9766-2-asmaa@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kEdobICLCmpuclNb"
Content-Disposition: inline
In-Reply-To: <20220920174736.9766-2-asmaa@nvidia.com>
Precedence: bulk


--kEdobICLCmpuclNb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 20, 2022 at 01:47:29PM -0400, Asmaa Mnebhi wrote:
> The i2c-mlxbf.c driver is currently broken because there is a bug
> in the calculation of the frequency. core_f, core_r and core_od
> are components read from hardware registers and are used to
> compute the frequency used to compute different timing parameters.
> The shifting mechanism used to get core_f, core_r and core_od is
> wrong. Use FIELD_GET to mask and shift the bitfields properly.
>=20
> Fixes: b5b5b32081cd206b (i2c: mlxbf: I2C SMBus driver for Mellanox BlueFi=
eld SoC)
> Reviewed-by: Khalil Blaiech <kblaiech@nvidia.com>
> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>

Applied to for-current, thanks!


--kEdobICLCmpuclNb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmMraaMACgkQFA3kzBSg
KbaDyxAArpwpuUrb/wfiY+JkxPCflO3ZZlFXlWe5Uw0RjM6gYUcE/xyZ3ulYi7sE
Gm0dcxcvB70a4PJod3w3/z0ELyUbS7pbnvIDpO7FUeJeG7bodeXbnLSFpN4rwOLv
ftNrs1KZMxJXr4/fzYUz5Kg7kCXr1GLstUwEbAfUoWmAyL7skW+FITPvY0mg7F+0
PmAOwUkRABB1WWGeioAK/ryHjOvyI0zmT0/8MV3K+1EHfTQVGIW8Nlr+BqOjhQqs
eQmgkbLuNaN4vUHVDfxXQ5Beuf/fP1HgdOqlL4ZhRWi2DG6Snx03GEoBgGMVgQda
sCx/QuhardNmBjCqhQA/GChxapHTpGf4y54o7t1kNUhIyUJwlSfPmbYLWxdFFK5j
hPo3/dXsrVRjM3YfJbbL3YA9TzGHO+9fRDFSQ/998wz5hvIRHgZOS6gGs9Wf8KWM
8vIxY5V6GDTMZ0gtalmHV6vFSB+lDkyJIoB5UBwQa5BzUBj405r4yh5sJUdFFx1C
5d08fLfn8VFxTgtJhP5VcCfgc1ND96lZ8dPWHIZN4DT5l2XxWzndHPTDoHE6m7tT
iEm6yRvjGI3k4/ra8nceCUSHlnslHaFmAA7HErQBCW05YP146bzM6eW8JrP49oAa
2CozuN86wKvK776hszp5z1w53xLCfyQ/VNj2N3DmSQb5M84J3Wc=
=UQHf
-----END PGP SIGNATURE-----

--kEdobICLCmpuclNb--