Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <df1e64e8-93e4-48e9-f49d-d85360ac006f@somainline.org>
Date:   Wed, 21 Sep 2022 23:07:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] dt-bindings: firmware: document Qualcomm SM6375 SCM
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        ~postmarketos/upstreaming@lists.sr.ht
Cc:     martin.botka@somainline.org,
        angelogioacchino.delregno@somainline.org,
        marijn.suijten@somainline.org, jamipkettunen@somainline.org,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Robert Marko <robimarko@gmail.com>,
        Das Srinagesh <quic_gurus@quicinc.com>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220921001020.55307-1-konrad.dybcio@somainline.org>
 <95fb2bfb-6eb8-012d-88f8-c739d229ef70@linaro.org>
 <8faecd72-0cfd-18eb-d07a-53b3a23ed05a@somainline.org>
 <f997cd3d-95c6-972f-032a-7646855371e1@linaro.org>
Content-Language: en-US
From:   Konrad Dybcio <konrad.dybcio@somainline.org>
In-Reply-To: <f997cd3d-95c6-972f-032a-7646855371e1@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 21.09.2022 21:06, Krzysztof Kozlowski wrote:
> On 21/09/2022 20:43, Konrad Dybcio wrote:
>>
>>
>> On 21.09.2022 09:07, Krzysztof Kozlowski wrote:
>>> On 21/09/2022 02:10, Konrad Dybcio wrote:
>>>> Document the compatible for Qualcomm SM6375 SCM.
>>>>
>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>>>> ---
>>>>  Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
>>>
>>> allOf needs to be updated.
>> Does it? I did not define this compatible in the driver, so it does
>> not consume any clocks.
> 
> It's about hardware, not driver. Hardware has some clocks. If it does
> not, then you need allOf disallowing it. Otherwise what do you expect in
> the clock entries?
Ok, so if I understand correctly then, all the compatibles that are in
the long long list in /properties/compatible/enum: should also be added
somewhere in the allOf: tree?

Konrad
> 
> Best regards,
> Krzysztof
>