Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1663555725-17016-1-git-send-email-wangyufen@huawei.com> <1663555725-17016-2-git-send-email-wangyufen@huawei.com>
In-Reply-To: <1663555725-17016-2-git-send-email-wangyufen@huawei.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Wed, 21 Sep 2022 17:38:10 -0700
Message-ID: <CAEf4BzabFB-__1bcYTb8E0ixS0dNZNcp9XNB-McWvQQ98sBR-Q@mail.gmail.com>
Subject: Re: [bpf-next v3 2/2] selftests/bpf: Add testcases for pinning to errpath
To:     Wang Yufen <wangyufen@huawei.com>
Cc:     andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
        martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
        haoluo@google.com, jolsa@kernel.org, paul.walmsley@sifive.com,
        palmer@dabbelt.com, aou@eecs.berkeley.edu, davem@davemloft.net,
        kuba@kernel.org, hawk@kernel.org, nathan@kernel.org,
        ndesaulniers@google.com, trix@redhat.com, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Sep 18, 2022 at 7:28 PM Wang Yufen <wangyufen@huawei.com> wrote:
>
> Add testcases for map and prog pin to errpath.
>
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---

let's drop this selftest, it does global system manipulations just to
check those two if conditions inside pathname_concat(), probably not
worth it.

Also for the future, we shouldn't use CHECK() in new selftests (we
still have CHECK()s because there are like 2 thousand of them in old
selftest, so clean up is not trivial).

>  tools/testing/selftests/bpf/prog_tests/pinning.c   | 67 ++++++++++++++++++++++
>  .../selftests/bpf/progs/test_pinning_path.c        | 19 ++++++
>  2 files changed, 86 insertions(+)
>  create mode 100644 tools/testing/selftests/bpf/progs/test_pinning_path.c
>

[...]