Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp150962rwb; Wed, 21 Sep 2022 19:21:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Rwc/JjUUdtfKF0+0EpWzujJlKEkF4Zca3Zj0z1mOJHQJ+1Vto6YHU/YK6YAxt8wASNz1B X-Received: by 2002:a17:902:f7ca:b0:178:9c90:b010 with SMTP id h10-20020a170902f7ca00b001789c90b010mr998736plw.149.1663813312072; Wed, 21 Sep 2022 19:21:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663813312; cv=none; d=google.com; s=arc-20160816; b=VIB1FQgEUlup99lrEUEkmYGYSdcArDcKaD9LHyJOOmXhWQ6D6IPj5FF49e21ruUK5c RIUY31eoopgMJy+PmOU/mWK6xToKlIBw6JVxlK/huHRu+A+MBRQMOW3JWJdozo0OMIqJ 7Uq8LY/VXEFbRoHJEA/utzrZYFXu0FBjMjvEM9jn4Sv1DscEEEbQkxWPlshYHslkGwcC tKOmCEIdlw9yI91JCxj39iVJivIYLUcxsnQQ3CVqMImjCp7E6KM4PMw0kak/Na0iclJW egJ79wDr2UtCRdzq1SEL8fV5cfbEHW7cTIBG4EnbQyshISAUS+hxoUddrewwJbk0nO3c PR4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=p7OsaPgDaE8pzyhnEYEnbmNVT1iMG/0i7m3psJG5hJU=; b=SB0hMabpDA/LLexTU2oK+DkFlf8x1XQEv3grP3XFv9n2b6NPvnbGeoDCigD5Ko4UZE NqDPM+YFfDSAupV8aHwAfjAwFgEoc8zRCsFwWbzljYjb83riV7W8IEfBQJHyVKy3OKbK GOBeTYr0sj6fXofC8o6frXDmltX/AMLuens+FRMIzTBAxSB6+IA6Fv8QYfNtAf1TzLlZ CGVZn86EOKYrnKA9pYsgE4VgKTxXNU7XYZBZxilSMnub7sdfgMqYhw0UZyDGulwr+s0A Syt8SpFxrEKDltxWR7OQrEtAo0I4OaeVl7Aar+d3x3UwCYZAjH6fJMisqCxBwCHXQ76d NUfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JTg+FuIU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y29-20020a63495d000000b00422c003b4c9si5242015pgk.46.2022.09.21.19.21.40; Wed, 21 Sep 2022 19:21:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JTg+FuIU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230262AbiIVB2z (ORCPT + 99 others); Wed, 21 Sep 2022 21:28:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbiIVB2x (ORCPT ); Wed, 21 Sep 2022 21:28:53 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C486A346F; Wed, 21 Sep 2022 18:28:53 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id 78so7654040pgb.13; Wed, 21 Sep 2022 18:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=p7OsaPgDaE8pzyhnEYEnbmNVT1iMG/0i7m3psJG5hJU=; b=JTg+FuIUoN7QXGLTOc5pFww5WflXJmVGLsZtoOkE8i4YVlX+2yEb0PC/sVFsJRhJho UIW979soJAyYIY53vQ+rtvJ4GZKWxhAHeFvtiiJVI+AhXYihOTKxgddzL8iIl+zSZ7/6 EhdpcEdGioqkfb0JkoPx/zDyRPjyUdTiPK6DJSHS+BwjTlQ0YnfIgeh8cx4564eVRycc NyKRSaT7xwW9CUd05TgKl+EJo9xsLgvRS+YStkMUEBOC4UAvfKyOfoB286al5ZNpRYX5 b7e4Q0AekBec0P0pVmOtxhql8zqNehth6WuR1/D4T7tA0rb7s/qwj/P35AHJgPL6qxMT GYLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=p7OsaPgDaE8pzyhnEYEnbmNVT1iMG/0i7m3psJG5hJU=; b=qlbgmdUD+TU9dRuNOVWcgnwB2/5QEn6iYBm5xlgmWSl89D7esf8DGtT5Xuv4dFK8fO yqudTrdMJ7SuEz77aRBAdEsiwiYabKJ1gbAPXr/bIf5QZ25l33sXupgGRWm7mfI3chC+ NhJNYGmicjxQeUM6bV88LcdW3ZNnTiPHQE5GSRpP+0GA1Zpr8eKnVDcL33j58+TBr0Jh b6MeSqH9uPHQD63e03vEMqxsLcP1ZyuQlT4aPE1RcHOZ3qL7KTNp/5evp2CBcK8WXT5p 47Kq+KlWa2qLkvbNPgqZORARq7azioHPAbGC6/rCQnGvG0w/8HBxc9RBqTU4TrVLAGYg jlUA== X-Gm-Message-State: ACrzQf39uloB8go5oU7L26UnSq3iBJ/JoLDtqAER83yelgD2n60crk+U VY5nVj+AEbRB6kfgAiNpUtI= X-Received: by 2002:a63:5d5b:0:b0:439:e032:4198 with SMTP id o27-20020a635d5b000000b00439e0324198mr940633pgm.398.1663810132100; Wed, 21 Sep 2022 18:28:52 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id b124-20020a636782000000b00439dfe09770sm2503724pgc.12.2022.09.21.18.28.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 18:28:51 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: ye.xingchen@zte.com.cn To: acme@kernel.org Cc: mingo@redhat.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, adrian.hunter@intel.com, irogers@google.com, ak@linux.intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, ye xingchen , Zeal Robot Subject: [PATCH linux-next] perf auxtrace: use strscpy() is more robust and safer Date: Thu, 22 Sep 2022 01:28:46 +0000 Message-Id: <20220922012846.232684-1-ye.xingchen@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ye xingchen The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings. Reported-by: Zeal Robot Signed-off-by: ye xingchen --- tools/perf/util/auxtrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c index b59c278fe9ed..81ee28983071 100644 --- a/tools/perf/util/auxtrace.c +++ b/tools/perf/util/auxtrace.c @@ -1208,7 +1208,7 @@ void auxtrace_synth_guest_error(struct perf_record_auxtrace_error *auxtrace_erro auxtrace_error->fmt = 1; auxtrace_error->ip = ip; auxtrace_error->time = timestamp; - strlcpy(auxtrace_error->msg, msg, MAX_AUXTRACE_ERROR_MSG); + strscpy(auxtrace_error->msg, msg, MAX_AUXTRACE_ERROR_MSG); if (machine_pid) { auxtrace_error->fmt = 2; auxtrace_error->machine_pid = machine_pid; -- 2.25.1