Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cb2f3c9c-ab45-357d-8a56-1c64b535633c@huawei.com>
Date:   Thu, 22 Sep 2022 10:29:06 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 1/2] ACPI: PCC: replace wait_for_completion()
To:     Sudeep Holla <sudeep.holla@arm.com>
CC:     <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <rafael@kernel.org>, <rafael.j.wysocki@intel.com>,
        <wanghuiqiang@huawei.com>, <huangdaode@huawei.com>
References: <20220920094500.11283-1-lihuisong@huawei.com>
 <20220920094500.11283-2-lihuisong@huawei.com>
 <20220921154737.az3d4ndxs3u3zwbl@bogus>
From:   "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <20220921154737.az3d4ndxs3u3zwbl@bogus>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/9/21 23:47, Sudeep Holla 写道:
> On Tue, Sep 20, 2022 at 05:44:59PM +0800, Huisong Li wrote:
>> Currently, the function waiting for completion of mailbox operation is
>> 'wait_for_completion()'.  The PCC method will be permanently blocked if
>> this mailbox message fails to execute. So this patch replaces it with
>> 'wait_for_completion_timeout()'. And set the timeout interval to an
>> arbitrary retries on top of nominal to prevent the remote processor is
>> slow to respond to PCC commands.
>>
> Sounds good to me. The only concern(may be not serious) is what happens
> if we receive response from the platform after the timeout. I have tested
If OS still cann't receive response in noramal latency(must be filled 
accurately
as protocol said) + retries, there is a high probability that an 
exception occurs.
Even if we receive response after the timeout, I think there may be no 
impact,
but the response data in PCC share memory is ignored.
> for that in non ACPI non PCC context. I don't have a setup to trigger that
> with ACPI PCC + this patch to test. Other than that, I am fine with this:
>
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
>