Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Sep 2022 10:36:25 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Russell King <linux@armlinux.org.uk>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jonathan Corbet <corbet@lwn.net>,
        kernel test robot <lkp@intel.com>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
        David Jander <david@protonic.nl>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Robert Marko <robert.marko@sartura.hr>
Subject: Re: [PATCH net-next v6 5/7] ethtool: add interface to interact with
 Ethernet Power Equipment
Message-ID: <YyvYOcfrur2mQXGl@debian.me>
References: <20220921124748.73495-1-o.rempel@pengutronix.de>
 <20220921124748.73495-6-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="MTrYSV5QHljcKwmR"
Content-Disposition: inline
In-Reply-To: <20220921124748.73495-6-o.rempel@pengutronix.de>
Precedence: bulk


--MTrYSV5QHljcKwmR
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 21, 2022 at 02:47:45PM +0200, Oleksij Rempel wrote:
> +PSE_GET
> +=3D=3D=3D=3D=3D=3D=3D
> +
> +Gets PSE attributes.
> +
> +Request contents:
> +
> +  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D  =3D=3D=3D=3D=3D=3D  =3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> +  ``ETHTOOL_A_PSE_HEADER``               nested  request header
> +  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D  =3D=3D=3D=3D=3D=3D  =3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> +
> +Kernel response contents:
> +
> +  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D  =3D=3D=3D=3D=3D=3D  =3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
> +  ``ETHTOOL_A_PSE_HEADER``                nested  reply header
> +  ``ETHTOOL_A_PODL_PSE_ADMIN_STATE``         u32  Operational state of t=
he PoDL
> +                                                  PSE functions
> +  ``ETHTOOL_A_PODL_PSE_PW_D_STATUS``         u32  power detection status=
 of the
> +                                                  PoDL PSE.
> +  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D  =3D=3D=3D=3D=3D=3D  =3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
> +
> +When set, the optional ``ETHTOOL_A_PODL_PSE_ADMIN_STATE`` attribute iden=
tifies
> +the operational state of the PoDL PSE functions.  The operational state =
of the
> +PSE function can be changed using the ``ETHTOOL_A_PODL_PSE_ADMIN_CONTROL=
``
> +action. This option is corresponding to IEEE 802.3-2018 30.15.1.1.2
> +aPoDLPSEAdminState. Possible values are:

The IEEE 802.3-2018 keyword name can be enclosed within inline code block.

> +When set, the optional ``ETHTOOL_A_PODL_PSE_PW_D_STATUS`` attribute iden=
tifies
> +the power detection status of the PoDL PSE.  The status depend on intern=
al PSE
> +state machine and automatic PD classification support. This option is
> +corresponding to IEEE 802.3-2018 30.15.1.1.3 aPoDLPSEPowerDetectionStatu=
s.

Same here.

> +When set, the optional ``ETHTOOL_A_PODL_PSE_ADMIN_CONTROL`` attribute is=
 used
> +to control PoDL PSE Admin functions. This option is implementing
> +IEEE 802.3-2018 30.15.1.2.1 acPoDLPSEAdminControl. See

Same here too.

Otherwise LGTM.

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

--=20
An old man doll... just what I always wanted! - Clara

--MTrYSV5QHljcKwmR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCYyvYNAAKCRD2uYlJVVFO
o+8FAP4zK3UmIUdOQH+lNRAv2FK50AeVwbm1AMvGvBlNmvUuMQD/dfXyj23GsJk9
OY1S/EdG8ybdI9p0U3BXMpirdVdCuAs=
=B+4n
-----END PGP SIGNATURE-----

--MTrYSV5QHljcKwmR--