Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e3ccfc4e-e1b1-252f-cf46-7385dcd21dfd@gmail.com>
Date:   Thu, 22 Sep 2022 06:49:23 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [RFC PATCH 3/5] dt-bindings: iio: Add KX022A accelerometer
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Cosmin Tanislav <demonsingur@gmail.com>,
        Jagath Jog J <jagathjog1996@gmail.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <cover.1663760018.git.mazziesaccount@gmail.com>
 <eb3edbb63c117f93e8ec534f50d8e3cf91ab3041.1663760018.git.mazziesaccount@gmail.com>
 <482c5a54-3d53-5760-fc8e-8aa3b9341707@linaro.org>
 <7582e9e9-4558-ac33-a0f8-cb4e69d0628e@fi.rohmeurope.com>
 <1e9b83f5-67a9-c5ee-3ede-b26a6bde2263@linaro.org>
From:   Matti Vaittinen <mazziesaccount@gmail.com>
In-Reply-To: <1e9b83f5-67a9-c5ee-3ede-b26a6bde2263@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Good Morning Krzysztof,

On 9/21/22 22:56, Krzysztof Kozlowski wrote:
> On 21/09/2022 21:30, Vaittinen, Matti wrote:
>> Hi dee Ho Krzysztof,
>>
>> Thanks for looking through this!
>>
>> On 9/21/22 22:11, Krzysztof Kozlowski wrote:
>>> On 21/09/2022 13:45, Matti Vaittinen wrote:
>>>> KX022A is a 3-axis Accelerometer from ROHM/Kionix. The senor features
>>>> include variable ODRs, I2C and SPI control, FIFO/LIFO with watermark IRQ,
>>>> +
>>>> +maintainers:
>>>> +  - Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
>>
>> My own comment - switch the email to the gmail-one. Company mail is
>> unreliable at best..
>>
>>>> +
>>>> +description: |
>>>> +  KX022A is a 3-axis accelerometer supporting +/- 2G, 4G, 8G and 16G ranges,
>>>> +  output data-rates from 0.78Hz to 1600Hz and a hardware-fifo buffering.
>>>> +  KX022A can be accessed either via I2C or SPI.
>>>> +
>>>> +properties:
>>>> +  compatible: kionix,kx022a
>>>
>>> Missing const. I wonder how did it pass testing...
>>
>> I originally had
>> oneOf:
>>    items const ...
>> construct here as I had separate compatibles for *-spi and *-i2c. I am
>> unsure if I remembered to run the tests after dropping the extra
>> compatibles :| - Sorry! I'll fix this.
> 
> This should be just:
>    compatible:
>      const: foo,bar
> 
>>
>>>> +  io_vdd-supply: true
>>>
>>> No underscores, so io-vdd-supply
>>
>> The rationale behind the underscore is that the data-sheet uses terms
>> vdd and vdd_io (with underscore). I wanted to match the supply name to
>> what is used in the data-sheet. Not a big thing but I'd rather kept if
>> same as the data-sheet if the requirement of "no-underscores" is not
>> "hard". (If it is, then I'll drop the underscore).
> 
> Underscores trigger warnings at some dtc W level (W=1 or W=2) so they
> are not allowed.

Thanks for the explanation. I'll change this too.

Yours,
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~