Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Colin Foster <colin.foster@in-advantage.com>
To:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org
Cc:     Russell King <linux@armlinux.org.uk>,
        Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH v2 net-next 07/14] net: dsa: felix: populate mac_capabilities for all ports
Date:   Wed, 21 Sep 2022 21:00:55 -0700
Message-Id: <20220922040102.1554459-8-colin.foster@in-advantage.com>
In-Reply-To: <20220922040102.1554459-1-colin.foster@in-advantage.com>
References: <20220922040102.1554459-1-colin.foster@in-advantage.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KzzdkszRb/tM68/dS0/ZjdvXQzU05+cQJ8ODMnQ5v3bQsPY7Vc6oU43b2xjo?=
 =?us-ascii?Q?f0ZA1OhooXbPfWasKj3CbILwRaWV5Q84rGTS2x5uutCZ3qWM+hinS+Jnt8on?=
 =?us-ascii?Q?+mHVeogycywxijOp6c8C2Snshr0i8qBVJPs0S0k+hxTh8+yCjMLFBnDpQi0j?=
 =?us-ascii?Q?NM79lJEP6ztfnF0A9IoC/MCtGpayYb5mePptnkkVxT64fDIe2aQzWXt9KW+Z?=
 =?us-ascii?Q?Kg8q1boEvVvWxpYJiYvHqBjbRQ1zGdSk+98JW954iQ8lyuCMYUZNekFpX1v8?=
 =?us-ascii?Q?vDfwnyWmx3FTPVAgmf+UZ+83NhYuYvrnI9DDfxLXh+BuuBmWl+9ZGCMB9QOZ?=
 =?us-ascii?Q?mQhWW3swC43ukjKmyhgCYNmiNXbnQv4+pQtjX1GOFwdLGDKc9gvcQ0s2KRHc?=
 =?us-ascii?Q?aPi8PA8ZKIrnAZAmyoSDJc2KA68dfjivPdCfkKACufaw+CSZbEV0RgbqP3q9?=
 =?us-ascii?Q?QBcRcqdGIUCMzll+teXteHCL9tpsQ6PRw5Hx3VnOU4IdH3gNPz8nalUQS5yE?=
 =?us-ascii?Q?dwPpu1/c8uQ1krZUSpoUjH2M0JLYeJDiSYgmQ4khXMZ0MxPR0I5u/l92sR+q?=
 =?us-ascii?Q?LTK5KfxwhTRYGwFsCAXmS/DNLwT7c1sYK9lTpiQdE3izLxoG5bbxEazzfVkd?=
 =?us-ascii?Q?vmGn6ZYHEx7SPEcTx8MCUVM1vWB7BDZ9omR+BPd17DKBsZNcPgbxJyV0pT5v?=
 =?us-ascii?Q?/KSqsernNkejOiHQBiqjga/FSViXtv6jS62SeF5sllUEUyKNxVK60NKlmDss?=
 =?us-ascii?Q?+6Mxs88iNfE6SiteaNdxTd5AUD2fDTvMaS7S254k5QS8A88z20J0Zm47D3ha?=
 =?us-ascii?Q?B3rFL4R72GzzfCVEZnGcxsLA2RnzDIBrELRVARYH3FzJOA+VpqwtTaTs6Kpe?=
 =?us-ascii?Q?/nV7e0vOBHx4rR8c6J9i9ReQ8/A09UrAATrYVZT5r65J8lTtyAq2nWyj6aq1?=
 =?us-ascii?Q?Mw9RtD//xYJXP9myyK2EdtsCR01ZbJ6rO1lfB+RiWVthnFGged2QcF+4hEJ+?=
 =?us-ascii?Q?qmJvaPBfcu1Eq4LybjEiVEZxlzjoh3RfuT3Efj/oJviwf2+mFy/0IYFf5Sgd?=
 =?us-ascii?Q?4fzTJGli7d0yWjGn2ZLGcHG0heEwOFCjtdA973EI2HqlJj180WCR2HX70q59?=
 =?us-ascii?Q?LhVDhbiMCIzVIVV3W0VGeLS3VIUp9T4o2TsUDe75yUdd1tLShHtEUUXiKXDP?=
 =?us-ascii?Q?hZm/Oa8K1Z2HRGWo8XBmBMHnRB8lknT2+BOVsK6OL3xzVJT3zasE6NCXVxcC?=
 =?us-ascii?Q?LMWkf+XkgLp+FSwopfjNz5jrU67ukLUDrF2+akzYtneeVzASDgfPRSx/ntEq?=
 =?us-ascii?Q?nfyF52pO2lNZ/3+0bvaGJeVdPbIMMFgD8a1g30oCmmG053V/8bN03AfGkvmR?=
 =?us-ascii?Q?kZS3joPhxyEOZdRxI/HKITpZN/O8s4CEnmapwuRdwLD6KBO/cqoZ/qTusVup?=
 =?us-ascii?Q?q4oUo5JRWLGo8kYOomwrDwK4epVbQ4F1+oKUI9M5EBpA5/eCi95AcNQ+qcN2?=
 =?us-ascii?Q?1ltsVQALEuSmw6UF3lZbHMZnnvT58qOEP1+UrB7NVmdUTtdZPFMRVEOCVu3Q?=
 =?us-ascii?Q?TPNnR2dCJ7wToH535kKIyrMg+F9OB7S0/jPtTPpoZX1gIO4Ptoug50tL/6j6?=
 =?us-ascii?Q?dA=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7d63a46-9bc6-49d4-a30f-08da9c4f208b
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1001MB2345.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 04:01:29.0592
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mMpe1oCSv6B5CUL5pIMGxPCo3K7cnz6uOIVvh+cFDfye08M8Py7rZmFVt0vLQecjB1aPzclTImETQeZoPh0U1H/73tFF9tt8KX1wEW4o1Yo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5158
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

phylink_generic_validate() requires that mac_capabilities is correctly
populated. While no existing felix drivers have used
phylink_generic_validate(), the ocelot_ext.c driver will. Populate this
element so the use of existing functions is possible.

Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
---

v2
    * Updated commit message to indicate "no existing felix drivers"
      instead of "no existing drivers"

v1 from previous RFC:
    * New patch

---
 drivers/net/dsa/ocelot/felix.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index 07c2f1b6913d..a8196cdedcc5 100644
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -1050,6 +1050,9 @@ static void felix_phylink_get_caps(struct dsa_switch *ds, int port,
 
 	__set_bit(ocelot->ports[port]->phy_mode,
 		  config->supported_interfaces);
+
+	config->mac_capabilities = MAC_SYM_PAUSE | MAC_ASYM_PAUSE | MAC_10 |
+				   MAC_100 | MAC_1000FD | MAC_2500FD;
 }
 
 static void felix_phylink_validate(struct dsa_switch *ds, int port,
-- 
2.25.1