Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253AbXFUINV (ORCPT ); Thu, 21 Jun 2007 04:13:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753206AbXFUINI (ORCPT ); Thu, 21 Jun 2007 04:13:08 -0400 Received: from nz-out-0506.google.com ([64.233.162.235]:26338 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753218AbXFUING (ORCPT ); Thu, 21 Jun 2007 04:13:06 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=IvttDfiItWmkdWRvd2bHVcIMi/1n43ejv6YwGIj3/wQt4gf1Czi+TxrqSjEAnY406SSjpik6Cv/LSVWTtSBVtJRMdKNwE9uGEzEtVd5bdsdGmwS4+F6BmQnt45RjIbKQ7pMkcPNWEi6h0vqd4vbDX8jLWFC9pGIW4ISSgdXDnpA= Message-ID: Date: Thu, 21 Jun 2007 13:43:05 +0530 From: "Satyam Sharma" To: "Christoph Hellwig" , "Satyam Sharma" , "Tom Spink" , "Toralf F?rster" , linux-kernel@vger.kernel.org, "Paolo Giarrusso" , "David Woodhouse" , linux-mtd@lists.infradead.org Subject: Re: build failure due to ROOT_DEV in mtd module (was Re: linux-2.6.22-rc5-g7c8545e build #298 failed ...) In-Reply-To: <20070621065920.GA9792@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070621065920.GA9792@infradead.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1752 Lines: 35 On 6/21/07, Christoph Hellwig wrote: > On Thu, Jun 21, 2007 at 12:22:01PM +0530, Satyam Sharma wrote: > > >> The build seems to fail because of: > > >> ERROR: "ROOT_DEV" [drivers/mtd/maps/nettel.ko] undefined! > > >> > > >> After taking a quick look at the code, I can't immediately see why > > >> this would be, since there is an include for linux/root_dev.h at the > > >> top, there. > > >> > > >> There's only one occurrence of ROOT_DEV (line 425), and after a quick > > >> look at the git history, it seems the include was originally missing, > > >> but was put back in, in commit > > >> 6cc449c7d0292cb9b993f0df84fd3225e3099492. > > Please just the reference to ROOT_DEV from this driver. Just because > someone builds this driver there should be no change in the default root > device. I agree, but this (drivers/mtd/maps/nettel.c) isn't the only modular driver referencing ROOT_DEV. We also have drivers/mtd/maps/pmcmsp-ramroot.c using ROOT_DEV (in fact the purpose of that driver seems to be precisely to special-case the root fs and do something with it ...) but considering that other driver's (tristate) Kconfig option depends on another symbol that is non-existent in the mainline tree, there is no way someone can build pmcmsp-ramroot and so we'll never actually hit that problem even with an allmodconfig build. Anyway, I'll leave this up to David / linux-mtd to sort out. [ No other modular user of ROOT_DEV in the tree other than the two mtd drivers mentioned here. ] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/