Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp396626rwb; Thu, 22 Sep 2022 00:48:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6WsVGgFfCM2MemSdw2vaFPrqc9FgA30zQrUMMGYvWZCqKy2iP+VMSgx1hqLh2xLjw0Zd83 X-Received: by 2002:a17:902:724a:b0:177:fd96:37bf with SMTP id c10-20020a170902724a00b00177fd9637bfmr1908652pll.25.1663832906843; Thu, 22 Sep 2022 00:48:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663832906; cv=none; d=google.com; s=arc-20160816; b=jkRuI2JUfoDERP6PUxXgMnzFBPtbzd0CEaqhj0Pp9VNRLOuphD59ykFko1k4RlUTPi zcfWJfAC7d60irqr20DVLMuQO4w3jF8O7OTtdEYutmcJAPrj+WuzGSxj9EppSF/8g+zX Es8Tdjee7pb6sEX0MUbi6k2174zVhR4PFw0KIBkPPo47w6P3V4d6ZbKA8B2wVJHCF39G vDmM74zGmnexWaX/MFvA+Kqilh8nvGtjx1V/kh22yA2Y889bB3RxXTrihEwQSxMEtilI Nc5a9QVtzW7FVD1vXDmu6aS1fbW2srba/a5Up9YUZC8eRlVZmblhIA1j40ip6hkB/74q vk9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=fVcE2reQEfaEop4WRxdK1mO72Ip3uJjJkJGgaluoDsM=; b=O4a//K4bvWo2uZ5Mfnq4OTi5BVXPjpDxX/erK7ozJPE3KBs20IWiWaw+bsoc9vqxYa 4dQndXATHpjxO4UkRRjZZULxrSbSW8iaPdRqgBzSi5W1xBfZdU9FNuayyJnpQhmfjkmg +cfAAFeT2L4ywnFS7cvOKJyzEi893rX6jVA/OhYKLAo09euNWRa7tH8nDI/tmttj1rRh Z8uSgP0dYllufqvXQpNPzO03rPhmDkuFkvIlqKSdh1MsxZrd5BaBVy3T0uJTxc7ASdcP Xb95JOrl2o4lyyceV+sjeld2CoMTa1SG9Vey3tL/oTa0TE+3kLImPGLJreXHV+VvOhyo jNUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MSlRGljb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id by3-20020a056a00400300b00537ee52f4e7si5149662pfb.140.2022.09.22.00.48.13; Thu, 22 Sep 2022 00:48:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MSlRGljb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230484AbiIVHYg (ORCPT + 99 others); Thu, 22 Sep 2022 03:24:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229902AbiIVHYe (ORCPT ); Thu, 22 Sep 2022 03:24:34 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE34AC41 for ; Thu, 22 Sep 2022 00:24:29 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id z25so13237613lfr.2 for ; Thu, 22 Sep 2022 00:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=fVcE2reQEfaEop4WRxdK1mO72Ip3uJjJkJGgaluoDsM=; b=MSlRGljboTuGCdg3YEgOuKZBwTHCYcmzhnbgNphcxRdZyyfnwC664T8n53L+7Kb5A1 cBjGVu/xWbq4oUq8SLl+K3rsUKIyb/pAPtYAe6Ak01fZY6SfyZEnTaLs/z3BMKPjkSgv vjmGQIgs1lLjxNx/uTL+ut/giC8XhZcsQwMrTBvzpBex0lB1/0LvbylWJluy/Ic3INLQ SjlutBZR81gnaEMn5Jc0oha2px1AkGagITF9BddZQkinMio1PuFwtZLaGSUmLItkLHzB 1LEDnf+uCMw/DTWJNW0akGZdDtngxnSDEMs68J10o1m+HzEjBBsp1pp6Xc4Uce8MuQ5O YqVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=fVcE2reQEfaEop4WRxdK1mO72Ip3uJjJkJGgaluoDsM=; b=i5wmfGflNhC3ziNAjBpIlsnIBrgt9y/nzT3i4fDcWPRHvm28Z9MoU7lxFFUzasDCzi nFywntq1mvcQXDr3ZxOlrKrPJD5bMHpapu4bqTzAMIPwwh6387GcyP22SLgAKuyePxEW K34wimJLZeMfucLIqq1Z/1E4qy6FZKwEXmS0Vp+IZo2mDx+Gure4oSHoHObWD7JgMt9M 6gYU9QNQAjFAa9veM2bwWXgCyRApcPKZD/qwQoB3EWxdjPOlgZPi+/VUOi7w/lYqgdX+ cm8nNSrkB+VUuT1XZYZD0jkALhRJcP7SVQKl7Jjg2YUhw3h9+7d32DigUfXHJGxMkXGU N9Ow== X-Gm-Message-State: ACrzQf1meCcN/iaGvQnloQRuixpFBgg0nkfNMLr+M1zpsbWoixA0rfUB kqDAGLFVWu3UW2eQXNezD9HCKA== X-Received: by 2002:a05:6512:370c:b0:49f:c4fb:8706 with SMTP id z12-20020a056512370c00b0049fc4fb8706mr723544lfr.635.1663831468306; Thu, 22 Sep 2022 00:24:28 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id j5-20020a2e6e05000000b0026c59d3f557sm769428ljc.33.2022.09.22.00.24.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 00:24:27 -0700 (PDT) Message-ID: Date: Thu, 22 Sep 2022 09:24:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v1 11/17] drm/mediatek: hdmi: add mt8195 support Content-Language: en-US To: Guillaume Ranquet , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-11-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220919-v1-11-4844816c9808@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/09/2022 18:56, Guillaume Ranquet wrote: > Adds hdmi and hdmi-ddc support for mt8195. > > Signed-off-by: Guillaume Ranquet > +static int mtk_hdmi_ddc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_hdmi_ddc *ddc; > + int ret; > + > + ddc = devm_kzalloc(dev, sizeof(struct mtk_hdmi_ddc), GFP_KERNEL); > + if (!ddc) > + return -ENOMEM; > + > + ddc->regs = syscon_regmap_lookup_by_compatible("mediatek,mt8195-hdmi"); That's not how you get regmaps. If you the driver grows, are you going to grow the list to e.g. 10 syscon_regmap_lookup_by_compatible() calls? This has to be by phandle. Best regards, Krzysztof